OSDN Git Service

drm/amd/display: don't initialize result
authorStefan Agner <stefan@agner.ch>
Sun, 17 Jun 2018 08:53:38 +0000 (10:53 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 5 Jul 2018 21:38:46 +0000 (16:38 -0500)
The wrong enum type is used to initialize the result, leading to a
warning when using clang:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1998:26: warning:
      implicit conversion from enumeration type 'enum ddc_result' to different
      enumeration type 'enum dc_status' [-Wenum-conversion]
        enum dc_status result = DDC_RESULT_UNKNOWN;
                       ~~~~~~   ^~~~~~~~~~~~~~~~~~
1 warning generated.

Initialization of result is unnecessary anyway, just drop the
initialization.

Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

index 049fc5c..84586b6 100644 (file)
@@ -2000,7 +2000,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd
 {
        union hpd_irq_data hpd_irq_dpcd_data = {{{{0}}}};
        union device_service_irq device_service_clear = { { 0 } };
-       enum dc_status result = DDC_RESULT_UNKNOWN;
+       enum dc_status result;
        bool status = false;
        /* For use cases related to down stream connection status change,
         * PSR and device auto test, refer to function handle_sst_hpd_irq