vfs: use READ_ONCE() to access ->i_link

Use 'READ_ONCE(inode->i_link)' to explicitly support filesystems caching
the symlink target in ->i_link later if it was unavailable at iget()
time, or wasn't easily available.  I'll be doing this in fscrypt, to
improve the performance of encrypted symlinks on ext4, f2fs, and ubifs.

->i_link will start NULL and may later be set to a non-NULL value by a
smp_store_release() or cmpxchg_release().  READ_ONCE() is needed on the
read side.  smp_load_acquire() is unnecessary because only a data
dependency barrier is required.  (Thanks to Al for pointing this out.)

Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/namei.c b/fs/namei.c
index d5e5140..0f13ff0 100644 (file)
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1027,7 +1027,7 @@ const char *get_link(struct nameidata *nd)
                return ERR_PTR(error);
 
        nd->last_type = LAST_BIND;
-       res = inode->i_link;
+       res = READ_ONCE(inode->i_link);
        if (!res) {
                const char * (*get)(struct dentry *, struct inode *,
                                struct delayed_call *);
@@ -4651,9 +4651,11 @@ int generic_readlink(struct dentry *dentry, char __user *buffer, int buflen)
 {
        DEFINE_DELAYED_CALL(done);
        struct inode *inode = d_inode(dentry);
-       const char *link = inode->i_link;
+       const char *link;
        int res;
 
+       link = READ_ONCE(inode->i_link);
+
        if (!link) {
                link = inode->i_op->get_link(dentry, inode, &done);
                if (IS_ERR(link))