OSDN Git Service

drm/fsl-dcu: use clk helpers
authorStefan Agner <stefan@agner.ch>
Fri, 12 Feb 2016 00:56:30 +0000 (16:56 -0800)
committerStefan Agner <stefan@agner.ch>
Sun, 19 Jun 2016 01:34:24 +0000 (18:34 -0700)
Use clk_prepare_enable and clk_disable_unprepare helpers. This also
fixes a sequence issue in the enable path which lead to a warning
on resume.

Signed-off-by: Stefan Agner <stefan@agner.ch>
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c

index 9daca1f..06a4d01 100644 (file)
@@ -232,8 +232,7 @@ static int fsl_dcu_drm_pm_suspend(struct device *dev)
        drm_kms_helper_poll_disable(fsl_dev->drm);
        regcache_cache_only(fsl_dev->regmap, true);
        regcache_mark_dirty(fsl_dev->regmap);
-       clk_disable(fsl_dev->clk);
-       clk_unprepare(fsl_dev->clk);
+       clk_disable_unprepare(fsl_dev->clk);
 
        return 0;
 }
@@ -246,15 +245,9 @@ static int fsl_dcu_drm_pm_resume(struct device *dev)
        if (!fsl_dev)
                return 0;
 
-       ret = clk_enable(fsl_dev->clk);
+       ret = clk_prepare_enable(fsl_dev->clk);
        if (ret < 0) {
                dev_err(dev, "failed to enable dcu clk\n");
-               clk_unprepare(fsl_dev->clk);
-               return ret;
-       }
-       ret = clk_prepare(fsl_dev->clk);
-       if (ret < 0) {
-               dev_err(dev, "failed to prepare dcu clk\n");
                return ret;
        }