OSDN Git Service

Do not merge: Don't show cab when invoking select text from menu
authorCary Clark <cary@android.com>
Tue, 21 Sep 2010 18:28:49 +0000 (14:28 -0400)
committerCary Clark <cary@android.com>
Tue, 21 Sep 2010 18:48:29 +0000 (14:48 -0400)
Leave the experiment intact for posterity.
Also, remove spurious comment.

Change-Id: I44519d4cf6843acf9aa056a6452e0e34216f2968
http://b/2626451

src/com/android/browser/BrowserActivity.java

index aca7003..098e3b2 100644 (file)
@@ -1287,7 +1287,6 @@ public class BrowserActivity extends Activity
     }
 
     private WebView showDialog(WebDialog dialog) {
-        // Need to do something special for Tablet
         Tab tab = mTabControl.getCurrentTab();
         if (tab.getSubWebView() == null) {
             // If the find or select is being performed on the main webview,
@@ -1399,7 +1398,14 @@ public class BrowserActivity extends Activity
                 break;
 
             case R.id.select_text_id:
-                showSelectDialog();
+                if (true) {
+                    Tab currentTab = mTabControl.getCurrentTab();
+                    if (currentTab != null) {
+                        currentTab.getWebView().setUpSelect();
+                    }
+                } else {
+                    showSelectDialog();
+                }
                 break;
 
             case R.id.page_info_menu_id: