OSDN Git Service

Prevent possible OutOfBoundsException
authorMartin Brabham <optedoblivion@cyngn.com>
Fri, 15 May 2015 20:27:56 +0000 (13:27 -0700)
committerGerrit Code Review <gerrit@cyanogenmod.org>
Tue, 19 May 2015 03:11:01 +0000 (03:11 +0000)
Change-Id: I8fc90a2ade069764732c35b71c5ae450d5d3cc5a

src/com/cyanogenmod/filemanager/ui/widgets/NavigationView.java

index 4f02b5d..88fd47b 100644 (file)
@@ -164,6 +164,12 @@ BreadcrumbListener, OnSelectionChangedListener, OnSelectionListener, OnRequestRe
             try {
                 // Response if the item can be removed
                 FileSystemObjectAdapter adapter = (FileSystemObjectAdapter)parent.getAdapter();
+
+                // Short circuit to protect OOBE
+                if (position < 0 || position >= adapter.getCount()) {
+                    return false;
+                }
+
                 FileSystemObject fso = adapter.getItem(position);
                 if (fso != null) {
                     if (fso instanceof ParentDirectory) {