OSDN Git Service

Remove ToastController.
authorAndrew Sapperstein <asapperstein@google.com>
Thu, 14 Apr 2016 22:11:33 +0000 (15:11 -0700)
committerAndrew Sapperstein <asapperstein@google.com>
Wed, 20 Apr 2016 16:54:13 +0000 (16:54 +0000)
Wasn't meant to be submitted.

Change-Id: Icc94daaf47ed85cefb59f20928241ef38d5ee2ca
(cherry picked from commit 17047d19396b9c01dd7d3daf92ef327f1eafc650)

src/com/android/settings/SettingsActivity.java
src/com/android/settings/overlay/FeatureFactory.java
src/com/android/settings/overlay/FeatureFactoryImpl.java
src/com/android/settings/overlay/ToastController.java [deleted file]

index 066e26e..176ab7e 100644 (file)
@@ -682,9 +682,6 @@ public class SettingsActivity extends SettingsDrawerActivity
             }
         }
 
-        // Will remove this line before submitting.
-        FeatureFactory.getFactory(this).createToastController().makeToast(this);
-
         if (DEBUG_TIMING) Log.d(LOG_TAG, "onCreate took " + (System.currentTimeMillis() - startTime)
                 + " ms");
     }
index a5e779d..b0b2a3f 100644 (file)
@@ -59,13 +59,7 @@ public abstract class FeatureFactory {
         return sFactory;
     }
 
-    /**
-     * Creates stub controller that makes {@link android.widget.Toast}s.
-     * Will be removed before submitting.
-     */
-    public abstract ToastController createToastController();
-
-    public static class FactoryNotFoundException extends RuntimeException {
+    public static final class FactoryNotFoundException extends RuntimeException {
         public FactoryNotFoundException(Throwable throwable) {
             super("Unable to create factory. Did you misconfigure Proguard?", throwable);
         }
index 4220bc0..036b4e7 100644 (file)
 
 package com.android.settings.overlay;
 
-import android.content.Context;
-import android.widget.Toast;
-
 /**
  * {@link FeatureFactory} implementation for AOSP Settings.
  */
 public class FeatureFactoryImpl extends FeatureFactory {
-    @Override
-    public ToastController createToastController() {
-        return new ToastController() {
-            @Override
-            public void makeToast(Context context) {
-                Toast.makeText(context, "Here's a piece of AOSP toast", Toast.LENGTH_LONG).show();
-            }
-        };
-    }
 }
diff --git a/src/com/android/settings/overlay/ToastController.java b/src/com/android/settings/overlay/ToastController.java
deleted file mode 100644 (file)
index d009ce2..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-package com.android.settings.overlay;
-
-import android.content.Context;
-
-/**
- * Will be removed before submitting. Just a proof of concept for review.
- */
-public interface ToastController {
-    void makeToast(Context context);
-}