OSDN Git Service

DarkUIPreferenceController null exception
authorJay Aliomer <aaliomer@google.com>
Thu, 21 Nov 2019 15:44:57 +0000 (10:44 -0500)
committerJay Aliomer <aaliomer@google.com>
Thu, 21 Nov 2019 20:07:34 +0000 (20:07 +0000)
The DarkUIPreferenceController doesnt need to show dialog in all cases
we added a null check for mFragment

Fixes: 144899194
Test: atest DarkUIPreferenceControllerTest
Change-Id: Ia5ed89bd46f28f4b92d955911223f9157e55c622
(cherry picked from commit c49f266af0f834ef6db1d53fab80ab8fbfcbb382)

src/com/android/settings/display/DarkUIPreferenceController.java

index d3d30b5..b85511d 100644 (file)
@@ -100,7 +100,7 @@ public class DarkUIPreferenceController extends TogglePreferenceController imple
 
     private void showDarkModeDialog() {
         final DarkUIInfoDialogFragment frag = new DarkUIInfoDialogFragment();
-        if (mFragment.getFragmentManager() != null) {
+        if (mFragment != null && mFragment.getFragmentManager() != null) {
             frag.show(mFragment.getFragmentManager(), getClass().getName());
         }
     }