OSDN Git Service

DO NOT MERGE Use default key permissions for ext4enc
authorPaul Lawrence <paullawrence@google.com>
Tue, 5 May 2015 18:06:43 +0000 (11:06 -0700)
committerPaul Lawrence <paullawrence@google.com>
Fri, 29 May 2015 21:18:37 +0000 (14:18 -0700)
(cherry-picked from commit 478a01d6f2081f7807b99774d005fee373847f23)

As per discussion default permissions are the correct ones.
Note that since we use logon keys, they cannot be read outside
the kernel.

Note also that we limit who can read/write keys in selinux policy.

Bug: 18151196
Change-Id: I15dc0de92643ae1472b0cde79c464fb3e1a1d453

ext4_utils/ext4_crypt_init_extensions.cpp

index cd0a02a..92445e6 100644 (file)
@@ -129,13 +129,6 @@ int e4crypt_install_keyring()
     KLOG_INFO(TAG, "Keyring created wth id %d in process %d\n",
               device_keyring, getpid());
 
-    // ext4enc:TODO set correct permissions
-    long result = keyctl_setperm(device_keyring, 0x3f3f3f3f);
-    if (result) {
-        KLOG_ERROR(TAG, "KEYCTL_SETPERM failed with error %ld\n", result);
-        return -1;
-    }
-
     return 0;
 }