OSDN Git Service

cryptfs: Remove Speck support
authorGreg Kaiser <gkaiser@google.com>
Wed, 1 Aug 2018 20:15:19 +0000 (13:15 -0700)
committerGreg Kaiser <gkaiser@google.com>
Tue, 7 Aug 2018 17:19:23 +0000 (10:19 -0700)
Remove the Speck encryption support. It was eventually
decided not to allow Speck in Android P, so this code
is no longer needed and wasn't used outside of testing.

Note we don't just "git revert" the original commit
(38723f23ff521e95ed295f500e6529c52a994c9f) because we want
to retain the infrastructure for allowing new types of
crypto algorithms in the future.

Bug: 112009351
Test: Attempted to setup a device with ro.crypto.fde_algorithm set to Speck, and Speck was rejected and the system defaulted to AES.
Change-Id: I69a8b4e8632f8d30b5b54783cb986ab42d4397d9

cryptfs.cpp

index 2ab3d09..c5024ae 100644 (file)
@@ -317,10 +317,6 @@ constexpr CryptoType default_crypto_type = CryptoType()
 
 constexpr CryptoType supported_crypto_types[] = {
     default_crypto_type,
-    CryptoType()
-        .set_property_name("Speck128/128-XTS")
-        .set_crypto_name("speck128-xts-plain64")
-        .set_keysize(32),
     // Add new CryptoTypes here.  Order is not important.
 };