OSDN Git Service

省略可能な部分を省略
authormasakih <masakih@users.sourceforge.jp>
Tue, 21 Mar 2017 14:43:03 +0000 (23:43 +0900)
committermasakih <masakih@users.sourceforge.jp>
Tue, 21 Mar 2017 14:43:03 +0000 (23:43 +0900)
KCD/BroserWindowController.swift
KCD/ChangeHenseiCommand.swift
KCD/FleetViewController.swift
KCD/JSONMapper.swift
KCD/MaterialMapper.swift
KCD/ScreenshotListViewController.swift
KCD/SetActionCommand.swift
KCD/ShipMapper.swift
KCD/ShipViewController.swift
KCD/SlotItemMapper.swift

index 7a20c55..335ba88 100644 (file)
@@ -120,9 +120,9 @@ class BroserWindowController: NSWindowController {
         bind("flagShipID", to: deckContoller, withKeyPath: "selection.ship_0", options: nil)
         
         NotificationCenter.default
-            .addObserver(forName: .CombinedDidCange, object: nil, queue: nil) { (notification) in
+            .addObserver(forName: .CombinedDidCange, object: nil, queue: nil) {
                 guard UserDefaults.standard.autoCombinedView,
-                    let type = notification.userInfo?[CombinedCommand.userInfoKey] as? CombineType
+                    let type = $0.userInfo?[CombinedCommand.userInfoKey] as? CombineType
                     else { return }
                 if !Thread.isMainThread { Thread.sleep(forTimeInterval: 0.1) }
                 DispatchQueue.main.async {
@@ -458,11 +458,12 @@ extension BroserWindowController {
         let o = selectedMainTabIndex
         selectedMainTabIndex = o
         
-        changeMainTabHandler = { [unowned self] newValue in
+        changeMainTabHandler = { [weak self] in
+            guard let `self` = self else { return }
             self.shipTypeButton.dismissPopover(nil)
             self.shipTypeSegment.unbind(NSSelectedIndexBinding)
             guard let button = self.shipTypeButton.view as? NSButton else { return }
-            let vc = self.tabViewItemViewControllers[newValue]
+            let vc = self.tabViewItemViewControllers[$0]
             button.isHidden = !vc.hasShipTypeSelector
             self.shipTypeSegment.bind(NSSelectedIndexBinding,
                                       to: vc,
index 6bdf615..dc8025f 100644 (file)
@@ -126,11 +126,12 @@ class ChangeHenseiCommand: JSONCommand {
     
     private func packFleet(store: ServerDataStore) {
         store.decksSortedById()
-            .forEach { (deck) in
+            .forEach { deck in
                 var needsPack = false
                 (0..<6).forEach {
                     let shipId = deck.shipId(of: $0)
-                    if (shipId == nil || shipId! == -1) && !needsPack {
+                    // TODO: うまいことする 強制アンラップを消す
+                    if (shipId == nil || shipId! == -1), !needsPack {
                         needsPack = true
                         return
                     }
index 2df45c4..fb0610f 100644 (file)
@@ -122,14 +122,14 @@ class FleetViewController: NSViewController {
     
     fileprivate var ships: [Ship] = [] {
         willSet {
-            ships.forEach { (ship) in
+            ships.forEach { ship in
                 shipObserveKeys.forEach {
                     ship.removeObserver(self, forKeyPath: $0)
                 }
             }
         }
         didSet {
-            ships.forEach { (ship) in
+            ships.forEach { ship in
                 shipObserveKeys.forEach {
                     ship.addObserver(self, forKeyPath: $0, context: &shipsContext)
                 }
index 17884ef..29713fa 100644 (file)
@@ -78,7 +78,7 @@ extension JSONMapper {
     
     func registerElement(_ element: JSON, to object: ObjectType) {
         beginRegister(object)
-        element.forEach { (key: String, value: JSON) in
+        element.forEach { (key, value) in
             if configuration.ignoreKeys.contains(key) { return }
             if handleExtraValue(value, forKey: key, to: object) { return }
             switch value.type {
index 586115b..75e1a91 100644 (file)
@@ -64,8 +64,7 @@ class MaterialMapper: JSONMapper {
     
     private func register(_ material: Material, data: [Int]) {
         data.enumerated().forEach {
-            guard $0.offset < keys.count
-                else { return }
+            guard $0.offset < keys.count else { return }
             material.setValue($0.element as NSNumber, forKey: keys[$0.offset])
         }
     }
index fc3f189..6893a89 100644 (file)
@@ -211,7 +211,7 @@ class ScreenshotListViewController: NSViewController {
         
         // 新しいものを追加
         let new: [ScreenshotInformation] = newFiles.flatMap { url in
-            let index = current.index { (info) -> Bool in url == info.url }
+            let index = current.index { url == $0.url }
             return index == nil ? ScreenshotInformation(url: url) : nil
         }
         
index 7d11d18..fc68a39 100644 (file)
@@ -28,7 +28,7 @@ class SetActionCommand: JSONCommand {
         if rIds.count != actions.count { print("missmatch count") }
         
         let store = ServerDataStore.oneTimeEditor()
-        zip(rIds, actions).forEach { (rId: Int, action: Int) in
+        zip(rIds, actions).forEach { (rId, action) in
             store.airBase(area: areaId, base: rId)?.action_kind = action
         }
     }
index d6a917e..fcdf534 100644 (file)
@@ -103,21 +103,18 @@ class ShipMapper: JSONMapper {
     func handleExtraValue(_ value: JSON, forKey key: String, to ship: Ship) -> Bool {
         // 取得後破棄した装備のデータを削除するため保有IDを保存
         if key == "api_id" {
-            guard let id = value.int
-                else { return false }
+            guard let id = value.int else { return false }
             registerIds.append(id)
             return false
         }
         
         if key == "api_ship_id" {
-            guard let masterId = value.int
-                else { return false }
+            guard let masterId = value.int else { return false }
             setMaster(masterId, to: ship)
             return true
         }
         if key == "api_exp" {
-            guard let exp = value[0].int
-                else { return false }
+            guard let exp = value[0].int else { return false }
             ship.exp = exp
             return true
         }
@@ -126,8 +123,7 @@ class ShipMapper: JSONMapper {
             return false
         }
         if key == "api_slot_ex" {
-            guard let ex = value.int
-                else { return false }
+            guard let ex = value.int else { return false }
             setExtraSlot(ex, to: ship)
             return false
         }
@@ -153,13 +149,13 @@ class ShipMapper: JSONMapper {
             let store = store
             else { return }
         let newItems: [SlotItem] =
-            converSlotItems.flatMap { (item: Int) in
+            converSlotItems.flatMap { item in
                 if item == 0 || item == -1 { return nil }
                 guard let found = self.slotItems.binarySearch(comparator: { $0.id ==? item }),
                     let slotItem = store.object(with: found.objectID) as? SlotItem
                     else {
                         let maxV = converSlotItems.last
-                        if maxV != nil && maxV! < item {
+                        if maxV != nil, maxV! < item {
                             #if DEBUG
                                 print("item is maybe unregistered, so it is new ship's equipment.")
                             #endif
index 5054f21..3cb6df4 100644 (file)
@@ -72,8 +72,8 @@ class ShipViewController: MainTabVIewItemViewController {
         tableViews
             .forEach {
                 NotificationCenter.default
-                    .addObserver(forName: .NSScrollViewDidEndLiveScroll, object: $0, queue: nil) { notification in
-                        guard let target = notification.object as? NSScrollView else { return }
+                    .addObserver(forName: .NSScrollViewDidEndLiveScroll, object: $0, queue: nil) {
+                        guard let target = $0.object as? NSScrollView else { return }
                         let visibleRect = target.documentVisibleRect
                         tableViews
                             .filter { $0 != target }
index 6718cb7..91df97d 100644 (file)
@@ -49,15 +49,13 @@ class SlotItemMapper: JSONMapper {
     func handleExtraValue(_ value: JSON, forKey key: String, to object: SlotItem) -> Bool {
         // 取得後破棄した装備のデータを削除するため保有IDを保存
         if key == "api_id" {
-            guard let id = value.int
-                else { return false }
+            guard let id = value.int else { return false }
             registerIds.append(id)
             return false
         }
         
         if key == "api_slotitem_id" {
-            guard let id = value.int
-                else { return false }
+            guard let id = value.int else { return false }
             setMaster(id, to: object)
             return true
         }
@@ -75,8 +73,7 @@ class SlotItemMapper: JSONMapper {
     }
     
     private func setMaster(_ masterId: Int, to slotItem: SlotItem?) {
-        guard let slotItem = slotItem
-            else { return }
+        guard let slotItem = slotItem else { return }
         if slotItem.slotitem_id == masterId { return }
         
         guard let mSlotItem = masterSlotItems.binarySearch(comparator: { $0.id ==? masterId })