implement size option for QPngHandler

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

free libspng context if QImage creation fails

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

merge master and adjust

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop auxiliary QImage data

no reason to store it when it is calculated from the DPI

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Merge branch 'master' of https://scm.osdn.net/gitroot/kde/Katie into spng

QImage::rgbSwapped() optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

warn if QImage is null in QPngHandler::read()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not assume pHYs chunk is available in QPngHandler

read benchmark results:
********* Start testing of tst_QImageReader *********
Config: Using QTest library 4.13.0, Katie 4.13.0
PASS  : tst_QImageReader::initTestCase()
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.kat":
     0.460 msecs per iteration (total: 230, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.kat":
     12.35 msecs per iteration (total: 6,177, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.kat":
     4.630 msecs per iteration (total: 2,315, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.png":
     1.69 msecs per iteration (total: 845, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.png":
     21.014 msecs per iteration (total: 10,507, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.png":
     11.17 msecs per iteration (total: 5,585, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.ppm":
     0.756 msecs per iteration (total: 378, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.ppm":
     2.958 msecs per iteration (total: 1,479, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.ppm":
     2.664 msecs per iteration (total: 1,332, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.svg":
     10.77 msecs per iteration (total: 5,385, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.xpm":
     8.344 msecs per iteration (total: 4,172, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.xpm":
     76.738 msecs per iteration (total: 38,369, iterations: 500)
RESULT   : tst_QImageReader::readImage():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.xpm":
     65.280 msecs per iteration (total: 32,640, iterations: 500)
PASS  : tst_QImageReader::readImage()
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.kat":
     1.98 msecs per iteration (total: 990, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.kat":
     13.31 msecs per iteration (total: 6,657, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.kat":
     5.590 msecs per iteration (total: 2,795, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.png":
     3.218 msecs per iteration (total: 1,609, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.png":
     23.224 msecs per iteration (total: 11,612, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.png":
     12.72 msecs per iteration (total: 6,362, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.ppm":
     1.64 msecs per iteration (total: 822, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.ppm":
     3.898 msecs per iteration (total: 1,949, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.ppm":
     3.630 msecs per iteration (total: 1,815, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.svg":
     9.304 msecs per iteration (total: 4,652, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench.xpm":
     9.858 msecs per iteration (total: 4,929, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-large.xpm":
     77.880 msecs per iteration (total: 38,940, iterations: 500)
RESULT   : tst_QImageReader::setScaledSize():"/home/smil3y/katie/tests/benchmarks/gui/image/qimagereader//images/bench-transparent.xpm":
     66.030 msecs per iteration (total: 33,015, iterations: 500)
PASS  : tst_QImageReader::setScaledSize()
PASS  : tst_QImageReader::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped
********* Finished testing of tst_QImageReader *********

write benchmark results:
********* Start testing of tst_QImageWriter *********
Config: Using QTest library 4.13.0, Katie 4.13.0
PASS  : tst_QImageWriter::initTestCase()
RESULT   : tst_QImageWriter::writeImage():"kat":
     2.450 msecs per iteration (total: 1,225, iterations: 500)
RESULT   : tst_QImageWriter::writeImage():"png":
     16.28 msecs per iteration (total: 8,142, iterations: 500)
RESULT   : tst_QImageWriter::writeImage():"ppm":
     7.176 msecs per iteration (total: 3,588, iterations: 500)
PASS  : tst_QImageWriter::writeImage()
PASS  : tst_QImageWriter::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped
********* Finished testing of tst_QImageWriter *********

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

handle pHYs chunk in QPngHandler

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QPngHandler rewrite to use libspng

no benchmarks done yet

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

fix random buffer filling in qRandomUuid() function

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

prefix the QML state debug config option

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use the QOpacityEffect::cancel() method in qFadeEffect() function

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

FreeBSD footprint file update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use https://scm.osdn.net/gitroot/kde/Katie.git to clone the Katie source for the FreeBSD package

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QSettings setup optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

update bundled libdeflate to v1.18

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

update URL TLDs table data

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop now unused scripttools component

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct indentation in rotated270() function

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QEasingCurve copy constructor optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant bits in qRandomUuid() function

at first I was thinking about making it compliant with the RFC but then I
figured none of the use-cases require it to be compliant (e.g.
partitionmanager and the tools that use the generated UUID)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop support for changing QDataStream precision

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

mark some QThreadPool branches as unlikely

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

mark QThreadPoolThread::run() as final

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

format and indent qthreadpool source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused and internal QThreadPoolPrivate::stealRunnable() method

was used by QFutureInterface

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

someone's typo

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

save errno before calling any other function in QLocalServerPrivate::setError()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused QTcpServerPrivate members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused socket exception notification

doubles as performance optimization for sockets (QTcpServer and QUdpSocket)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

implement default QStatInfo constructor and use it as optimization in QFileSystemWatcherPrivate::_q_timeout()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not manually set the socket state and error of QTcpServer

that means that once the socket engine is closed the error becomes unknown
tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant pointer check in QTcpServer::listen()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove the unused gamma option of QImageWriter

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove now unused katie_setup_object() macro

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

fix regression since 51f2253d73b140638853c97b1351c19ec7e8fa4f

png_read_image() handles interlacing internally

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove BSD workarounds

if the linker cannot find system libraries then it's not a Katie build
system problem

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

update PROJECT_LOGO in doxygen.conf

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

static QFile methods optimizations

the QFile::remove() and QFile::rename() methods are used a lot (e.g. to
remove or move temporary files) so the optimization will be noticable

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QFile documentation review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QFileSystemIterator optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

mark the error case in qt_unix_query() as unlikely

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused qmap header inclusion in qlibrary source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

qt_unix_query() function optimization

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

keep reference to QByteArray object in QLibraryPrivate::load_sys()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

const-ify QFactoryLoaderPrivate::suffix member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

merge QFileSystemWatcherEngineUnix into QFileSystemWatcherPrivate

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

track watched files and directories only in QFileSystemWatcherEngineUnix

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

simplify emision of QFileSystemWatcher signals

the proxy signals are just redundant

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

reuse QFontDatabase object in tst_QCssParser::extractFontFamily_data()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

make Debian package depend on fonts-freefont-ttf

it is the last resort font

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

update tables data to CLDR v42

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

update URL TLDs table data

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant QFontInfo class

QFontDatabase::font() does the same (i.e. resolves the font)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

do not return boolean from QBitArray::fill()

the return value is always true

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

drop support for custom QEasingCurve type

use one of the animation classes instead if such is required

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

search for programs in the standard executables locations in addition to PATH

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

look for the program before exec-ing from QProcess

stat-ing multiple times is much more optimal than exec-ing multiple times,
bonus points for using QStandardPaths::findExecutable() to look for the
program (which should check for it in ~/.local/bin too)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

version bump

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant QTextControl::event() reimplementation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

use correct QString constructor for expected data in tst_QJsonDocument::read()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

always use QImage for QTextDocument resources

now that QPixmap always uses QImage (internally) it's better to use QImage
directly

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

check the time even if the serial is the same in QKeyMapper::translateKeyEvent()

apparently X11 sends key events with same serial even seconds after (if the
key is the same), also now only key presses will be considered
auto-repeated because X11 sends (fake/simulated) key release events

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

move the static variable outside the conditional code in QKeyMapper::translateKeyEvent()

fun fact: it is very easy to break auto-repeat code by reparenting QWidget
from a QPushButton event (KMediaWidget does it)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct memcmp() return value checks in QTextConverter::toUnicode()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

return if ubrk_safeClone() fails in QTextBoundaryFinder assignment operator

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

call ubrk_following() and ubrk_preceding() with the current QTextBoundaryFinder position

I remember ubrk_following() and ubrk_preceding() causing a crash if the
position is not within the text bounds so leaving the -1 checks just in
case

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

check for self-assignment in QTextBoundaryFinder assignment operator

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

handle strings as UTF-8 encoded from QJsonDocument

the default QString codec is US-ASCII

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

chop BOMs from QTextConverter::toUnicode()

fun fact: anything that is checking for BOMs is either not passing them
to QTextCodec/QTextConverter (e.g. Kate) when converting or was just using
QTextCodec::IgnoreHeader flag (QXmlStreamWriter used to)

okular xps generator now works btw (xml files in .xps files seem to be
UTF-16 encoded with BOM)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QPngHandler::write() optimization

why allocate when it can be done without?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

inherit std::bitset<T> as private base class of QTimersSet

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct indendations in qslider source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused QSizeGripPrivate member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused definitions in qsizegrip source file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct break scope in QDockWidget::event()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QApplication and QWidgetAnimator friendship has been broken

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

partial build fix for the case when QT_NO_COLORDIALOG is defined

qtconfig tool requires QColorDialog, that's why it is broken

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QT_NO_FILEDIALOG config option is no longer broken

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QT_NO_FONTDIALOG config option is no longer broken

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct indentation in QWindowsStyle::drawPrimitive()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove redundant check in QEasingCurve::setType()

since QEasingCurve instances are no longer shared and no detaching is done
the check that was optimization to avoid detaching is no longer worth it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct repo directory name in crossdeb.sh script

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QFontDatabase review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QEasingCurve review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

move the QEasingCurve::Custom case to the switch in QEasingCurve::valueForProgress()

side note: only plasma and KWin set custom QEasingCurve function, both are
not used

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

translations update

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove resource system leftovers

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

correct debug message in QTextStreamPrivate::flushWriteBuffer()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

write BOM only from QTextStream, on demand

ICU finally does not generate BOMs (since idk when), I guess someone took
note. chopping BOMs from the result may have to be done only if the input
data had BOM (for compat) but let's see if that is even needed

Kate encoding tests pass now btw

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

consistent QTextConverter::ConversionFlag enums

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove most of the QTextStream manipulators and the ambiguous void pointer operator

most of them are unused since QTextStream is used mostly for streaming to
QFile, besides that the streaming of void pointer could result in streaming
in std::endl function pointer address or some other non-sense

I will not gut-out QTextStream yet (not in this release cycle) because I
know for a fact such change will break things that use the declarative
component (such as plasma and its applets due to nan/inf compat code in
QTextStream)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

test QTextConverter::hasFailure() in QTextCodec test

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

call UCNV_FROM_U_CALLBACK_SUBSTITUTE() and UCNV_TO_U_CALLBACK_SUBSTITUTE() with NULL as context

what a surprise it is to learn that both function replace characters only
in some cases (when context is NULL or some internally set context)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

someone's typo

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

copy the other object position from QTextBoundaryFinder copy-constructor

as done by the assignment operator

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QTextBoundaryFinder documentation review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

remove unused HB_MIN(), HB_MAX() and HB_FIXED_CONSTANT() macros defined in qharfbuz_p header

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

QEasingCurve::valueForProgress() optimization

doing qreal (either float or double) math on demand is much more optimal,
also reducing the switches to one is a bonus

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>