OSDN Git Service

ACPI: check a return value correctly in acpi_power_get_context()
authorLi Zefan <lizf@cn.fujitsu.com>
Fri, 18 Apr 2008 20:27:29 +0000 (13:27 -0700)
committerWilly Tarreau <w@1wt.eu>
Sun, 1 Jun 2008 18:23:58 +0000 (20:23 +0200)
[backport of 2.6 commit a815ab8b5891f3d2515316655729272f68269e3b]

We should check *resource != NULL rather than resource != NULL, which will be
always true.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Zhao Yakui <yakui.zhao@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/acpi/power.c

index 2510040..3bda6ad 100644 (file)
@@ -90,7 +90,7 @@ acpi_power_get_context (
        }
 
        *resource = (struct acpi_power_resource *) acpi_driver_data(device);
-       if (!resource)
+       if (!*resource)
                return_VALUE(-ENODEV);
 
        return_VALUE(0);