こちらがベストプラクティスですね

diff --git a/tool/Unit2.dfm b/tool/Unit2.dfm
index 8b7cb77..3a22d8e 100644 (file)
--- a/tool/Unit2.dfm
+++ b/tool/Unit2.dfm
@@ -127,7 +127,6 @@ object Form1: TForm1
     Height = 17
     Caption = 'mente'
     TabOrder = 8
-    OnClick = CheckBox1Click
   end
   object Edit3: TEdit
     Left = 80
@@ -171,7 +170,6 @@ object Form1: TForm1
     Max = 300
     Position = 30
     TabOrder = 13
-    OnClick = UpDown1Click
   end
   object Edit6: TEdit
     Left = 80
@@ -186,7 +184,6 @@ object Form1: TForm1
     Width = 145
     Height = 21
     TabOrder = 15
-    OnSelect = ComboBox1Select
   end
   object Button6: TButton
     Left = 509

diff --git a/tool/Unit2.pas b/tool/Unit2.pas
index a38b6e5..424e4c5 100644 (file)
--- a/tool/Unit2.pas
+++ b/tool/Unit2.pas
@@ -73,9 +73,6 @@ type
     procedure Button3Click(Sender: TObject);
     procedure FormCreate(Sender: TObject);
     procedure Button6Click(Sender: TObject);
-    procedure ComboBox1Select(Sender: TObject);
-    procedure CheckBox1Click(Sender: TObject);
-    procedure UpDown1Click(Sender: TObject; Button: TUDBtnType);
     procedure Button5Click(Sender: TObject);
     procedure SpeedButton1Click(Sender: TObject);
     procedure ListBox1KeyDown(Sender: TObject; var Key: Word;
@@ -176,6 +173,8 @@ begin
 end;
 
 procedure TForm1.Button6Click(Sender: TObject);
+var
+  i: Integer;
   function hash(str: string): string;
   begin
     with TIdHashSHA1.Create do
@@ -189,31 +188,28 @@ procedure TForm1.Button6Click(Sender: TObject);
   end;
 
 begin
-  if Edit6.Text <> '' then
-    FDTable2.FieldByName('password').AsString := hash(hash(Edit6.Text));
-  if ComboBox1.Items.IndexOf(ComboBox1.Text) = -1 then
-  begin
-    ComboBox1.ItemIndex := 0;
-    ComboBox1Select(nil);
-  end;
-  FDTable2.Post;
   list;
-  FDTable2.ApplyUpdates;
-  FDTable2.CommitUpdates;
   FDTable3.ApplyUpdates;
   FDTable3.CommitUpdates;
-  FDTable2.Edit;
-end;
-
-procedure TForm1.CheckBox1Click(Sender: TObject);
-var
-  i: Integer;
-begin
-  if CheckBox1.Checked = true then
-    i := 1
-  else
-    i := 0;
-  FDTable2.FieldByName('mente').AsInteger := i;
+  with FDTable2 do
+  begin
+    Edit;
+    if Edit6.Text <> '' then
+      FieldByName('password').AsString := hash(hash(Edit6.Text));
+    if CheckBox1.Checked = true then
+      i := 1
+    else
+      i := 0;
+    FieldByName('mente').AsInteger := i;
+    if ComboBox1.Items.IndexOf(ComboBox1.Text) = -1 then
+      ComboBox1.ItemIndex := 0;
+    FieldByName('info').AsInteger := FDTable3.Lookup('database',
+      ComboBox1.Text, 'dbnum');
+    FieldByName('count').AsInteger := UpDown1.Position;
+    Post;
+    ApplyUpdates;
+    CommitUpdates;
+  end;
 end;
 
 procedure TForm1.combo;
@@ -239,12 +235,6 @@ begin
   ComboBox1.Items.Delete(i);
 end;
 
-procedure TForm1.ComboBox1Select(Sender: TObject);
-begin
-  FDTable2.FieldByName('info').AsInteger := FDTable3.Lookup('database',
-    ComboBox1.Text, 'dbnum');
-end;
-
 procedure TForm1.FormCreate(Sender: TObject);
 begin
   if FDTable1.Exists = false then
@@ -277,7 +267,6 @@ begin
   combo;
   CheckBox1.Checked := FDTable2.FieldByName('mente').AsInteger = 1;
   UpDown1.Position := FDTable2.FieldByName('count').AsInteger;
-  FDTable2.Edit;
 end;
 
 procedure TForm1.itemsCopy;
@@ -362,9 +351,4 @@ begin
   end;
 end;
 
-procedure TForm1.UpDown1Click(Sender: TObject; Button: TUDBtnType);
-begin
-  FDTable2.FieldByName('count').AsInteger := UpDown1.Position;
-end;
-
 end.