Fix a bug of Parallel hint

During manipulation on pathlist of a GatherPath, foreach was mitakenly
used for a loop using list_delete_cell. This leads to a crash with
SEGV.

diff --git a/pg_hint_plan.c b/pg_hint_plan.c
index 477c1f1..04540a5 100644 (file)
--- a/pg_hint_plan.c
+++ b/pg_hint_plan.c
@@ -4405,12 +4405,13 @@ pg_hint_plan_set_rel_pathlist(PlannerInfo * root, RelOptInfo *rel,
                /* also remove gather path */
                if (rel->pathlist)
                {
-                       ListCell *cell, *prev = NULL;
+                       ListCell *cell, *prev = NULL, *next;
 
-                       foreach (cell, rel->pathlist)
+                       for (cell = list_head(rel->pathlist) ; cell; cell = next)
                        {
                                Path *path = (Path *) lfirst(cell);
-                               
+
+                               next = lnext(cell);
                                if (IsA(path, GatherPath))
                                        rel->pathlist = list_delete_cell(rel->pathlist,
                                                                                                         cell, prev);