Properly change the state of parallel hints.

The state member of parallel hint is forgotten to be chaned on usage.
This fixes it.

diff --git a/expected/ut-W.out b/expected/ut-W.out
index 571a0eb..8b47fb3 100644 (file)
--- a/expected/ut-W.out
+++ b/expected/ut-W.out
@@ -23,8 +23,8 @@ EXPLAIN (COSTS false) SELECT * FROM s1.t1;
 EXPLAIN (COSTS false) SELECT * FROM s1.t1;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(t1 10 soft)
+not used hint:
 duplication hint:
 error hint:
 
@@ -39,8 +39,8 @@ error hint:
 EXPLAIN (COSTS false) SELECT * FROM s1.t1;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(t1 10 soft)
+not used hint:
 duplication hint:
 error hint:
 
@@ -55,8 +55,8 @@ error hint:
 EXPLAIN (COSTS false) SELECT * FROM s1.t1;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(t1 10 hard)
+not used hint:
 duplication hint:
 error hint:
 
@@ -72,8 +72,8 @@ error hint:
 EXPLAIN (COSTS false) SELECT * FROM p1;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(p1 10 soft)
+not used hint:
 duplication hint:
 error hint:
 
@@ -97,8 +97,8 @@ error hint:
 EXPLAIN (COSTS false) SELECT * FROM p1;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(p1 10 hard)
+not used hint:
 duplication hint:
 error hint:
 
@@ -139,8 +139,8 @@ EXPLAIN (COSTS false) SELECT * FROM p1_c1 join p2_c1 on p1_c1.id = p2_c1.id;
 EXPLAIN (COSTS false) SELECT * FROM p1_c1 join p2_c1 on p1_c1.id = p2_c1.id;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(p1_c1 10 hard)
+not used hint:
 duplication hint:
 error hint:
 
@@ -165,8 +165,8 @@ error hint:
 EXPLAIN (COSTS false) SELECT * FROM p1_c1 join p2_c1 on p1_c1.id = p2_c1.id;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(p2_c1 10 hard)
+not used hint:
 duplication hint:
 error hint:
 
@@ -191,9 +191,9 @@ error hint:
 EXPLAIN (COSTS false) SELECT * FROM p1_c1 join p2_c1 on p1_c1.id = p2_c1.id;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(p1_c1 10 hard)
 Parallel(p2_c1 10 hard)
+not used hint:
 duplication hint:
 error hint:
 
@@ -221,8 +221,8 @@ error hint:
 EXPLAIN (COSTS false) SELECT * FROM p1 join p2 on p1.id = p2.id;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(p1 10 soft)
+not used hint:
 duplication hint:
 error hint:
 
@@ -259,8 +259,8 @@ error hint:
 EXPLAIN (COSTS false) SELECT * FROM p1 join p2 on p1.id = p2.id;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(p2 10 hard)
+not used hint:
 duplication hint:
 error hint:
 
@@ -297,9 +297,9 @@ error hint:
 EXPLAIN (COSTS false) SELECT * FROM p1 join p2 on p1.id = p2.id;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(p1 5 hard)
 Parallel(p2 10 hard)
+not used hint:
 duplication hint:
 error hint:
 
@@ -357,8 +357,8 @@ EXPLAIN (COSTS false) SELECT * FROM p1;
 EXPLAIN (COSTS false) SELECT * FROM p1;
 LOG:  pg_hint_plan:
 used hint:
-not used hint:
 Parallel(p1 0 hard)
+not used hint:
 duplication hint:
 error hint:
 

diff --git a/pg_hint_plan.c b/pg_hint_plan.c
index 1ed9d65..9e0d15c 100644 (file)
--- a/pg_hint_plan.c
+++ b/pg_hint_plan.c
@@ -2531,8 +2531,11 @@ static void
 setup_parallel_plan_enfocement(ParallelHint *hint, HintState *state)
 {
        if (hint)
+       {
+               hint->base.state = HINT_STATE_USED;
                set_config_int32_option("max_parallel_workers_per_gather",
                                                                hint->nworkers, state->context);
+       }
        else
                set_config_int32_option("max_parallel_workers_per_gather",
                                                                state->init_nworkers, state->context);