BugTrack2/236: If you compare two numerical strings, they are compared as integers

diff --git a/plugin/article.inc.php b/plugin/article.inc.php
index 41f2f25..e9d2865 100644 (file)
--- a/plugin/article.inc.php
+++ b/plugin/article.inc.php
@@ -88,7 +88,7 @@ function plugin_article_action()
        $postdata_input = $article . "\n";
        $body = '';
 
-       if (md5(@join('', get_source($post['refer']))) != $post['digest']) {
+       if (md5(get_source($post['refer'], TRUE, TRUE)) !== $post['digest']) {
                $title = $_title_collided;
 
                $body = $_msg_collided . "\n";

diff --git a/plugin/comment.inc.php b/plugin/comment.inc.php
index e52a5e0..32dd4c5 100644 (file)
--- a/plugin/comment.inc.php
+++ b/plugin/comment.inc.php
@@ -68,7 +68,7 @@ function plugin_comment_action()
 
        $title = $_title_updated;
        $body = '';
-       if (md5(@join('', get_source($vars['refer']))) != $vars['digest']) {
+       if (md5(get_source($vars['refer'], TRUE, TRUE)) !== $vars['digest']) {
                $title = $_title_comment_collided;
                $body  = $_msg_comment_collided . make_pagelink($vars['refer']);
        }

diff --git a/plugin/edit.inc.php b/plugin/edit.inc.php
index dda7ff6..8fc0418 100644 (file)
--- a/plugin/edit.inc.php
+++ b/plugin/edit.inc.php
@@ -190,7 +190,7 @@ function plugin_edit_write()
        // Collision Detection
        $oldpagesrc = join('', get_source($page));
        $oldpagemd5 = md5($oldpagesrc);
-       if ($digest != $oldpagemd5) {
+       if ($digest !== $oldpagemd5) {
                $vars['digest'] = $oldpagemd5; // Reset
 
                $original = isset($vars['original']) ? $vars['original'] : '';

diff --git a/plugin/insert.inc.php b/plugin/insert.inc.php
index b19a181..bcf5e52 100644 (file)
--- a/plugin/insert.inc.php
+++ b/plugin/insert.inc.php
@@ -36,7 +36,7 @@ function plugin_insert_action()
        $postdata_input = $insert . "\n";
 
        $body = '';
-       if (md5(@join('', get_source($vars['refer']))) != $vars['digest']) {
+       if (md5(get_source($vars['refer'], TRUE, TRUE)) !== $vars['digest']) {
                $title = $_title_collided;
                $body  = $_msg_collided . "\n";
 

diff --git a/plugin/memo.inc.php b/plugin/memo.inc.php
index c0e6fe8..cba06c2 100644 (file)
--- a/plugin/memo.inc.php
+++ b/plugin/memo.inc.php
@@ -36,7 +36,7 @@ function plugin_memo_action()
        $postdata_input = $memo_body . "\n";
 
        $body = '';
-       if (md5(@join('', get_source($vars['refer']))) != $vars['digest']) {
+       if (md5(get_source($vars['refer'], TRUE, TRUE)) !== $vars['digest']) {
                $title = $_title_collided;
                $body  = $_msg_collided . "\n";
 

diff --git a/plugin/paint.inc.php b/plugin/paint.inc.php
index 6a7802e..347d655 100644 (file)
--- a/plugin/paint.inc.php
+++ b/plugin/paint.inc.php
@@ -256,7 +256,7 @@ function paint_insert_ref($filename)
        }
 
        // ¹¹¿·¤Î¾×Æͤò¸¡½Ð
-       if (md5(join('',$postdata_old)) != $vars['digest'])
+       if (md5(join('',$postdata_old)) !== $vars['digest'])
        {
                $ret['msg'] = $_paint_messages['msg_title_collided'];
                $ret['body'] = $_paint_messages['msg_collided'];

diff --git a/plugin/pcomment.inc.php b/plugin/pcomment.inc.php
index e56ee8b..6dadab0 100644 (file)
--- a/plugin/pcomment.inc.php
+++ b/plugin/pcomment.inc.php
@@ -209,7 +209,7 @@ function plugin_pcomment_insert()
                $count    = count($postdata);
 
                $digest = isset($vars['digest']) ? $vars['digest'] : '';
-               if (md5(join('', $postdata)) != $digest) {
+               if (md5(join('', $postdata)) !== $digest) {
                        $ret['msg']  = $_pcmt_messages['title_collided'];
                        $ret['body'] = $_pcmt_messages['msg_collided'];
                }

diff --git a/plugin/vote.inc.php b/plugin/vote.inc.php
index dd32508..afd10d8 100644 (file)
--- a/plugin/vote.inc.php
+++ b/plugin/vote.inc.php
@@ -47,7 +47,7 @@ function plugin_vote_action()
                $postdata      .= $vote_str;
        }
 
-       if (md5(@join('', get_source($vars['refer']))) != $vars['digest']) {
+       if (md5(get_source($vars['refer'], TRUE, TRUE)) !== $vars['digest']) {
                $title = $_title_collided;
 
                $s_refer          = htmlsc($vars['refer']);