OSDN Git Service

input: use %*pb[l] to print bitmaps including cpumasks and nodemasks
authorTejun Heo <tj@kernel.org>
Fri, 13 Feb 2015 22:37:48 +0000 (14:37 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 14 Feb 2015 05:21:38 +0000 (21:21 -0800)
printk and friends can now format bitmaps using '%*pb[l]'.  cpumask
and nodemask also provide cpumask_pr_args() and nodemask_pr_args()
respectively which can be used to generate the two printf arguments
necessary to format the specified cpu/nodemask.

* Line termination only requires one extra space at the end of the
  buffer.  Use PAGE_SIZE - 1 instead of PAGE_SIZE - 2 when formatting.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/input/keyboard/atkbd.c
drivers/input/keyboard/gpio_keys.c

index e27a258..387c51f 100644 (file)
@@ -1399,8 +1399,8 @@ static ssize_t atkbd_set_extra(struct atkbd *atkbd, const char *buf, size_t coun
 
 static ssize_t atkbd_show_force_release(struct atkbd *atkbd, char *buf)
 {
-       size_t len = bitmap_scnlistprintf(buf, PAGE_SIZE - 2,
-                       atkbd->force_release_mask, ATKBD_KEYMAP_SIZE);
+       size_t len = scnprintf(buf, PAGE_SIZE - 1, "%*pbl",
+                              ATKBD_KEYMAP_SIZE, atkbd->force_release_mask);
 
        buf[len++] = '\n';
        buf[len] = '\0';
index 883d6ae..ddf4045 100644 (file)
@@ -190,7 +190,7 @@ static ssize_t gpio_keys_attr_show_helper(struct gpio_keys_drvdata *ddata,
                __set_bit(bdata->button->code, bits);
        }
 
-       ret = bitmap_scnlistprintf(buf, PAGE_SIZE - 2, bits, n_events);
+       ret = scnprintf(buf, PAGE_SIZE - 1, "%*pbl", n_events, bits);
        buf[ret++] = '\n';
        buf[ret] = '\0';