OSDN Git Service
(root)
/
sagit-ice-cold
/
kernel_xiaomi_msm8998.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
eb4058d
)
USB: legousbtower: fix memleak on disconnect
author
Johan Hovold
<johan@kernel.org>
Thu, 10 Oct 2019 12:58:35 +0000
(14:58 +0200)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Tue, 29 Oct 2019 08:13:23 +0000
(09:13 +0100)
commit
b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2
upstream.
If disconnect() races with release() after a process has been
interrupted, release() could end up returning early and the driver would
fail to free its driver data.
Fixes:
1da177e4c3f4
("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link:
https://lore.kernel.org/r/20191010125835.27031-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/legousbtower.c
patch
|
blob
|
history
diff --git
a/drivers/usb/misc/legousbtower.c
b/drivers/usb/misc/legousbtower.c
index
20e3d57
..
32b41eb
100644
(file)
--- a/
drivers/usb/misc/legousbtower.c
+++ b/
drivers/usb/misc/legousbtower.c
@@
-425,10
+425,7
@@
static int tower_release (struct inode *inode, struct file *file)
goto exit;
}
- if (mutex_lock_interruptible(&dev->lock)) {
- retval = -ERESTARTSYS;
- goto exit;
- }
+ mutex_lock(&dev->lock);
if (dev->open_count != 1) {
dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n",