OSDN Git Service

pinctrl: sh-pfc: sh7734: Remove bogus IPSR10 value
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 13 Dec 2018 13:32:34 +0000 (14:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:21:37 +0000 (10:21 +0100)
[ Upstream commit 4d374bacd7c9665179f9752a52d5d602c45d8190 ]

The IP10[5:3] field in Peripheral Function Select Register 10 has a
width of 3 bits, i.e. it allows programming one out of 8 different
configurations.
However, 9 values are provided instead of 8, overflowing into the
subsequent field in the register, and thus breaking the configuration of
the latter.

Fix this by dropping a bogus zero value.

Fixes: ac1ebc2190f575fc ("sh-pfc: Add sh7734 pinmux support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/sh-pfc/pfc-sh7734.c

index a083530..ce543f3 100644 (file)
@@ -2236,7 +2236,7 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
                FN_LCD_CL1_B, 0, 0,
            /* IP10_5_3 [3] */
                FN_SSI_WS23, FN_VI1_5_B, FN_TX1_D, FN_HSCK0_C, FN_FALE_B,
-               FN_LCD_DON_B, 0, 0, 0,
+               FN_LCD_DON_B, 0, 0,
            /* IP10_2_0 [3] */
                FN_SSI_SCK23, FN_VI1_4_B, FN_RX1_D, FN_FCLE_B,
                FN_LCD_DATA15_B, 0, 0, 0 }