OSDN Git Service

msm: camera: Remove unnecessary parentheses in msm_cam_sensor_handle_reg_gpio
authorNathan Chancellor <natechancellor@gmail.com>
Wed, 24 Apr 2019 00:34:02 +0000 (17:34 -0700)
committerNathan Chancellor <natechancellor@gmail.com>
Fri, 27 Sep 2019 07:42:37 +0000 (00:42 -0700)
Clang warns:

../drivers/media/platform/msm/camera_v2/sensor/io/msm_camera_dt_util.c:1356:48:
warning: equality comparison with extraneous parentheses
[-Wparentheses-equality]
        if ((gconf->gpio_num_info->valid[gpio_offset] == 1)) {
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../drivers/media/platform/msm/camera_v2/sensor/io/msm_camera_dt_util.c:1356:48:
note: remove extraneous parentheses around the comparison to silence
this warning
        if ((gconf->gpio_num_info->valid[gpio_offset] == 1)) {
            ~                                         ^   ~
../drivers/media/platform/msm/camera_v2/sensor/io/msm_camera_dt_util.c:1356:48:
note: use '=' to turn this equality comparison into an assignment
        if ((gconf->gpio_num_info->valid[gpio_offset] == 1)) {
                                                      ^~
                                                      =
1 warning generated.

Fixes: 92a558c15e80 ("msm: camera: Add support to enable eLDOs through GPIOs")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
drivers/media/platform/msm/camera_v2/sensor/io/msm_camera_dt_util.c

index 457bd17..00860d0 100644 (file)
@@ -1353,7 +1353,7 @@ int msm_cam_sensor_handle_reg_gpio(int seq_val,
        CDBG("%s: %d GPIO offset: %d, seq_val: %d\n", __func__, __LINE__,
                gpio_offset, seq_val);
 
-       if ((gconf->gpio_num_info->valid[gpio_offset] == 1)) {
+       if (gconf->gpio_num_info->valid[gpio_offset] == 1) {
                gpio_set_value_cansleep(
                        gconf->gpio_num_info->gpio_num
                        [gpio_offset], val);