OSDN Git Service

Fixed lots of warnings
authorSylvain Vedrenne <svedrenne@jankenpoi.net>
Fri, 28 Dec 2012 18:39:05 +0000 (19:39 +0100)
committerSylvain Vedrenne <svedrenne@jankenpoi.net>
Fri, 28 Dec 2012 18:39:05 +0000 (19:39 +0100)
27 files changed:
src/classes/net/jankenpoi/sudokuki/generator/SudokuGenerator.java
src/classes/net/jankenpoi/sudokuki/generator/suexg/SuexgJava.java
src/classes/net/jankenpoi/sudokuki/model/GridChangedEvent.java
src/classes/net/jankenpoi/sudokuki/model/GridModel.java
src/classes/net/jankenpoi/sudokuki/preferences/UserPreferences.java
src/classes/net/jankenpoi/sudokuki/solver/BruteForceGridSolver.java
src/classes/net/jankenpoi/sudokuki/ui/swing/AboutAction.java
src/classes/net/jankenpoi/sudokuki/ui/swing/CheatMenu.java
src/classes/net/jankenpoi/sudokuki/ui/swing/CheckUpdateDialog.java
src/classes/net/jankenpoi/sudokuki/ui/swing/ClearAllMovesAction.java
src/classes/net/jankenpoi/sudokuki/ui/swing/CustomGridAction.java
src/classes/net/jankenpoi/sudokuki/ui/swing/EditMenu.java
src/classes/net/jankenpoi/sudokuki/ui/swing/EraseAllMemosAction.java
src/classes/net/jankenpoi/sudokuki/ui/swing/FileMenu.java
src/classes/net/jankenpoi/sudokuki/ui/swing/GridGenerationDialog.java
src/classes/net/jankenpoi/sudokuki/ui/swing/HelpMenu.java
src/classes/net/jankenpoi/sudokuki/ui/swing/LevelMenu.java
src/classes/net/jankenpoi/sudokuki/ui/swing/MenuBar.java
src/classes/net/jankenpoi/sudokuki/ui/swing/OpenGridAction.java
src/classes/net/jankenpoi/sudokuki/ui/swing/PlayCustomGridAction.java
src/classes/net/jankenpoi/sudokuki/ui/swing/ResolveAction.java
src/classes/net/jankenpoi/sudokuki/ui/swing/ResolveGridDialog.java
src/classes/net/jankenpoi/sudokuki/ui/swing/SaveAsAction.java
src/classes/net/jankenpoi/sudokuki/ui/swing/SelectMemosPanel.java
src/classes/net/jankenpoi/sudokuki/ui/swing/SetAllMemosAction.java
src/classes/net/jankenpoi/sudokuki/ui/swing/SetMemosHereAction.java
src/classes/net/jankenpoi/sudokuki/view/GridView.java

index abb1ec0..cd27409 100644 (file)
@@ -12,7 +12,7 @@ public abstract class SudokuGenerator {
                                System.out.println();\r
                        if (i % 27 == 0)\r
                                System.out.println();\r
-                       System.out.print("" + (tab[i] == 0 ? "-" : tab[i]));\r
+                       System.out.print("" + (tab[i] == 0 ? "-" : Integer.valueOf(tab[i])));\r
                }\r
                System.out.println();\r
        }\r
index 62d9bf5..31163ae 100644 (file)
@@ -216,7 +216,7 @@ class SuexgJava extends SuexgGenerator {
                        // mr1:\r
                        if (gotoMR1) {\r
                                gotoMR1 = false;\r
-                               i1 = (int) (MWC() >> 8) & 127;\r
+                               i1 = (MWC() >> 8) & 127;\r
                                if (i1 > 80) {\r
                                        gotoMR1 = true;\r
                                        continue; // these 2 instructions stand for: goto mr1;\r
@@ -232,7 +232,7 @@ class SuexgJava extends SuexgGenerator {
                        // mr3:\r
                        if (gotoMR3) {\r
                                gotoMR3 = false;\r
-                               s = (int) (MWC() >> 9) & 15;\r
+                               s = (MWC() >> 9) & 15;\r
                                if (s > 8) {\r
                                        gotoMR3 = true;\r
                                        continue; // these 2 instructions stand for: goto mr3;\r
@@ -268,7 +268,7 @@ class SuexgJava extends SuexgGenerator {
                                        x = i;\r
                                        while (x >= i) {\r
                                                // mr4:\r
-                                               x = (int) (MWC() >> 8) & 127;\r
+                                               x = (MWC() >> 8) & 127;\r
                                        }\r
                                        x++;\r
                                        P[i] = P[x];\r
@@ -393,7 +393,7 @@ class SuexgJava extends SuexgGenerator {
                                                        w++;\r
                                                        W[w] = c;\r
                                                }\r
-                                               ;\r
+                                               \r
                                                if (V[c] < min) {\r
                                                        w = 1;\r
                                                        W[w] = c;\r
@@ -408,7 +408,7 @@ class SuexgJava extends SuexgGenerator {
                        if (gotoMR) {\r
                                gotoMR = false;\r
 \r
-                               c2 = (int) (MWC() & Two[w]);\r
+                               c2 = (MWC() & Two[w]);\r
                                if (c2 >= w) {\r
                                        gotoMR = true;\r
                                        continue; // simulates: goto mr;\r
index 276238d..36846c0 100644 (file)
@@ -38,7 +38,7 @@ public class GridChangedEvent extends EventObject {
        }
 
        public short getInfos() {
-               return (short)infos;
+               return infos;
        }
        
 }
index f230ded..4f88983 100644 (file)
@@ -85,8 +85,8 @@ public class GridModel implements Cloneable {
        }
        
        private void newGrid() {
-               final int minRating = UserPreferences.getInstance().getInteger("minRating", 0);
-               final int maxRating = UserPreferences.getInstance().getInteger("maxRating", Integer.MAX_VALUE);
+               final int minRating = UserPreferences.getInstance().getInteger("minRating", Integer.valueOf(0)).intValue();
+               final int maxRating = UserPreferences.getInstance().getInteger("maxRating", Integer.valueOf(Integer.MAX_VALUE)).intValue();
                SudokuGrid grid = SudokuGeneratorFactory.getGenerator().generateGrid(minRating, maxRating);
 
                for (int i = 0; i < cellInfos.length; i++) {
@@ -111,7 +111,7 @@ public class GridModel implements Cloneable {
                                .println("GridModel.GridModel() length:" + strValues.length());
                System.out.println("GridModel.GridModel() strValues:" + strValues);
                for (int i = 0; i < strValues.length(); i++) {
-                       short value = Short.valueOf(strValues.substring(i, i + 1));
+                       short value = Short.valueOf(strValues.substring(i, i + 1)).shortValue();
                        System.out.print(value);
                        cellInfos[i] = value;
                        if (1 <= value && value <= 9) {
index 71736dd..ca2fa1a 100644 (file)
@@ -9,7 +9,7 @@ public class UserPreferences {
        static {\r
                INSTANCE.set("minRating", Integer.valueOf(0));\r
                INSTANCE.set("maxRating", Integer.valueOf(5700));\r
-               INSTANCE.set("kanjiMode", Boolean.FALSE);\r
+               INSTANCE.set("numbersMode", Integer.valueOf(0));\r
        }\r
 \r
        private final HashMap<String, Object> map = new HashMap<String, Object>();\r
index e591314..0fc4d43 100755 (executable)
@@ -28,7 +28,7 @@ public class BruteForceGridSolver implements GridSolver {
 \r
        private boolean cancelRequested() {\r
                synchronized (cancelled) {\r
-                       return cancelled;\r
+                       return cancelled.booleanValue();\r
                }\r
        }\r
        \r
index a150e7b..3d48de5 100644 (file)
@@ -20,7 +20,6 @@ package net.jankenpoi.sudokuki.ui.swing;
 import java.awt.event.ActionEvent;
 
 import javax.swing.AbstractAction;
-import javax.swing.Icon;
 import javax.swing.JFrame;
 
 @SuppressWarnings("serial")
@@ -28,8 +27,7 @@ public class AboutAction extends AbstractAction {
        
        private JFrame parent;
        
-       public AboutAction(JFrame parent, SwingGrid grid, String string, Icon iconHelpAbout,
-                       String desc, Integer mnemonic) {
+       public AboutAction(JFrame parent) {
                this.parent = parent;
        }
 
index 235344a..3152656 100644 (file)
@@ -60,12 +60,12 @@ public class CheatMenu extends JMenu implements L10nComponent {
         private final Action actionResolve;
         
         public CheatMenu(ActionsRepository actions, JFrame parent, GridView view) {
-                actionSetMemosHere = new SetMemosHereAction(parent, _("Memos"),
+                actionSetMemosHere = new SetMemosHereAction(_("Memos"),
                                 StockIcons.ICON_SET_MEMOS_HERE, _("Set memos"), new Integer(
                                                 KeyEvent.VK_T), view);
                 actions.put("SetMemosHere", actionSetMemosHere);
                 
-                actionSetAllMemos = new SetAllMemosAction(parent, _("All memos"),
+                actionSetAllMemos = new SetAllMemosAction(_("All memos"),
                                 StockIcons.ICON_SET_ALL_MEMOS, _("Set memos in all cells"), new Integer(
                                                 KeyEvent.VK_X), view);
                 actions.put("SetAllMemos", actionSetAllMemos);
index d94dc9c..adb3d98 100644 (file)
@@ -28,6 +28,7 @@ import java.io.InputStreamReader;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.net.URLConnection;
+import java.net.UnknownHostException;
 import java.util.concurrent.CancellationException;
 import java.util.concurrent.ExecutionException;
 
@@ -80,14 +81,8 @@ public class CheckUpdateDialog extends JDialog {
                                        result = 1;
                                }
                        } catch (InterruptedException e) {
-                               System.out
-                                               .println("CheckUpdateDialog.worker.new SwingWorker() {...}.done() Interrupted !!!!");
                        } catch (ExecutionException e) {
-                               System.out
-                                               .println("CheckUpdateDialog.worker.new SwingWorker() {...}.done() ExecutionException !!!!");
                        } catch (CancellationException e) {
-                               System.out
-                                               .println("CheckUpdateDialog.worker.new SwingWorker() {...}.done() CancellationException !!!!");
                                result = -2;
                        } finally {
                                CheckUpdateDialog.this.dispose();
@@ -113,11 +108,13 @@ public class CheckUpdateDialog extends JDialog {
                                line = dis.readLine();
                        } catch (MalformedURLException mue) {
                                mue.printStackTrace();
+                       } catch (UnknownHostException uhe) {
                        } catch (IOException ioe) {
-                               ioe.printStackTrace();
                        } finally {
                                try {
-                                       dis.close();
+                                   if (dis != null) {
+                                       dis.close();
+                                   }
                                } catch (IOException e) {
                                        e.printStackTrace();
                                }
index d293766..f416ba7 100644 (file)
@@ -21,7 +21,6 @@ import java.awt.event.ActionEvent;
 \r
 import javax.swing.AbstractAction;\r
 import javax.swing.Icon;\r
-import javax.swing.JFrame;\r
 \r
 import net.jankenpoi.sudokuki.view.GridView;\r
 \r
@@ -30,7 +29,7 @@ public class ClearAllMovesAction extends AbstractAction {
 \r
        private GridView view;\r
 \r
-       public ClearAllMovesAction(JFrame parent, String text, Icon icon,\r
+       public ClearAllMovesAction(String text, Icon icon,\r
                        String desc, Integer mnemonic, GridView view) {\r
                super(text, icon);\r
                \r
index ee73a54..8216e60 100644 (file)
@@ -21,7 +21,6 @@ import java.awt.event.ActionEvent;
 
 import javax.swing.AbstractAction;
 import javax.swing.Icon;
-import javax.swing.JFrame;
 
 import net.jankenpoi.sudokuki.view.GridView;
 
@@ -30,7 +29,7 @@ public class CustomGridAction extends AbstractAction {
 
        private GridView view;
 
-       public CustomGridAction(JFrame parent, String text, Icon icon,
+       public CustomGridAction(String text, Icon icon,
                        String desc, Integer mnemonic, GridView view) {
                super(text, icon);
                
index f756492..0c3211d 100644 (file)
@@ -67,22 +67,22 @@ public class EditMenu extends JMenu implements L10nComponent {
                 getAccessibleContext().setAccessibleDescription(\r
                                 "Edit menu");\r
                 \r
-                actionClearAllMoves = new ClearAllMovesAction(parent, "Clear all moves",\r
+                actionClearAllMoves = new ClearAllMovesAction("Clear all moves",\r
                                 StockIcons.ICON_CLEAR, "Clear all my moves", new Integer(\r
                                                 KeyEvent.VK_X), view);\r
                 actions.put("ClearAllMoves", actionClearAllMoves);\r
                 \r
-                actionEraseAllMemos = new EraseAllMemosAction(parent, "Erase all memos",\r
+                actionEraseAllMemos = new EraseAllMemosAction("Erase all memos",\r
                                 StockIcons.ICON_CLEAR_ALL_MEMOS, "Erase all memos...", new Integer(\r
                                                 KeyEvent.VK_X), view);\r
                 actions.put("EraseAllMemos", actionEraseAllMemos);\r
                 \r
-                actionCustomGrid = new CustomGridAction(parent, "Custom grid",\r
+                actionCustomGrid = new CustomGridAction("Custom grid",\r
                                 StockIcons.ICON_EDIT, "Compose a custom grid...", new Integer(\r
                                                 KeyEvent.VK_G), view);\r
                 actions.put("CustomGrid", actionCustomGrid);\r
 \r
-                actionPlayCustomGrid = new PlayCustomGridAction(parent, "Play custom grid",\r
+                actionPlayCustomGrid = new PlayCustomGridAction("Play custom grid",\r
                                 StockIcons.ICON_PLAY, "Play with current grid...", new Integer(\r
                                                 KeyEvent.VK_H), view);\r
                 actions.put("PlayCustomGrid", actionPlayCustomGrid);\r
index 9b2e3ca..7f5a84b 100644 (file)
@@ -21,7 +21,6 @@ import java.awt.event.ActionEvent;
 \r
 import javax.swing.AbstractAction;\r
 import javax.swing.Icon;\r
-import javax.swing.JFrame;\r
 \r
 import net.jankenpoi.sudokuki.view.GridView;\r
 \r
@@ -30,7 +29,7 @@ public class EraseAllMemosAction extends AbstractAction {
 \r
        private GridView view;\r
 \r
-       public EraseAllMemosAction(JFrame parent, String text, Icon icon,\r
+       public EraseAllMemosAction(String text, Icon icon,\r
                        String desc, Integer mnemonic, GridView view) {\r
                super(text, icon);\r
                \r
index ca63ea5..4f84a20 100644 (file)
@@ -94,14 +94,14 @@ public class FileMenu extends JMenu implements L10nComponent {
 \r
                actionNew = new NewGridAction(parent, view, actions);\r
                actions.put("NewGrid", actionNew);\r
-               actionOpen = new OpenGridAction(parent, view, actions);\r
+               actionOpen = new OpenGridAction(parent, view);\r
                actions.put("OpenGrid", actionOpen);\r
-               actionSaveAs = new SaveAsAction(parent, view, actions);\r
+               actionSaveAs = new SaveAsAction(parent, view);\r
                actions.put("SaveAs", actionSaveAs);\r
                actionPrint = new PrintAction(grid);\r
                actions.put("Print", actionPrint);\r
                actionPrintMulti = new PrintMultiAction(parent, view);\r
-               actions.put("PrintMulti", actionPrintMulti);;\r
+               actions.put("PrintMulti", actionPrintMulti);\r
                addItems();\r
                setL10nMessages(null, _("DETECTED_LANGUAGE"));\r
                localeListener = new LocaleListenerImpl(this);\r
index d5e704d..2d91388 100644 (file)
@@ -134,9 +134,9 @@ public class GridGenerationDialog extends JDialog {
                dispose();\r
        }\r
 \r
-       private int generateGrid() {\r
+       private Integer generateGrid() {\r
                view.getController().notifyNewGridRequested();\r
-               return 0;\r
+               return Integer.valueOf(0);\r
        }\r
 \r
 }\r
index 5cc4749..d38df7e 100644 (file)
@@ -30,7 +30,6 @@ import javax.swing.JMenuItem;
 import net.jankenpoi.i18n.I18n;\r
 import net.jankenpoi.i18n.LocaleListener;\r
 import net.jankenpoi.sudokuki.ui.L10nComponent;\r
-import net.jankenpoi.sudokuki.view.GridView;\r
 \r
 @SuppressWarnings("serial")\r
 public class HelpMenu extends JMenu implements L10nComponent {\r
@@ -71,7 +70,7 @@ public class HelpMenu extends JMenu implements L10nComponent {
                actionAbout.putValue(Action.MNEMONIC_KEY, new Integer(KeyEvent.VK_P));\r
        }\r
 \r
-       HelpMenu(ActionsRepository actions, JFrame frame, SwingGrid grid, GridView view) {\r
+       HelpMenu(ActionsRepository actions, JFrame frame) {\r
                this.parent = frame;\r
                setMnemonic(KeyEvent.VK_H);\r
                getAccessibleContext().setAccessibleDescription(\r
@@ -85,15 +84,15 @@ public class HelpMenu extends JMenu implements L10nComponent {
                actionTranslate = new TranslateAction(parent);\r
                actions.put("Translate", actionTranslate);\r
                \r
-               actionAbout = new AboutAction(parent, grid, "", null, "", Integer.valueOf(0));\r
+               actionAbout = new AboutAction(parent);\r
                actions.put("About", actionAbout);\r
-               addItems(view);\r
+               addItems();\r
                setL10nMessages(null, _("DETECTED_LANGUAGE"));\r
                localeListener = new LocaleListenerImpl(this);\r
                I18n.addLocaleListener(localeListener);\r
        }\r
 \r
-       private void addItems(GridView view) {\r
+       private void addItems() {\r
                itemCheckUpdate.setAction(actionCheckUpdate);\r
                add(itemCheckUpdate);\r
                \r
index b01706a..069df64 100644 (file)
@@ -133,8 +133,8 @@ public class LevelMenu extends JMenu implements L10nComponent {
        }\r
        \r
        private void setLevelRatingBounds(final int minRating, final int maxRating) {\r
-               UserPreferences.getInstance().set("minRating", minRating);\r
-               UserPreferences.getInstance().set("maxRating", maxRating);\r
+               UserPreferences.getInstance().set("minRating", Integer.valueOf(minRating));\r
+               UserPreferences.getInstance().set("maxRating", Integer.valueOf(maxRating));\r
        }\r
        \r
 }\r
index 01026d3..4d8c219 100644 (file)
@@ -35,7 +35,7 @@ public class MenuBar extends JMenuBar {
                add(new FileMenu(parent, actions, grid, view));\r
                editMenu = new EditMenu(actions, parent, view);\r
                add(editMenu);\r
-               add(new HelpMenu(actions, parent, grid, view));\r
+               add(new HelpMenu(actions, parent));\r
        }\r
 \r
        final CheatMenu getCheatMenu() {\r
index 5dd1c1c..93411b2 100644 (file)
@@ -41,7 +41,7 @@ public class OpenGridAction extends AbstractAction {
 
        private final JFrame frame;
        
-       OpenGridAction(JFrame frame, GridView view, ActionsRepository actions) {
+       OpenGridAction(JFrame frame, GridView view) {
                this.frame = frame;
                this.view = view;
        }
index 0fcee81..1065162 100644 (file)
@@ -21,7 +21,6 @@ import java.awt.event.ActionEvent;
 
 import javax.swing.AbstractAction;
 import javax.swing.Icon;
-import javax.swing.JFrame;
 
 import net.jankenpoi.sudokuki.view.GridView;
 
@@ -30,7 +29,7 @@ public class PlayCustomGridAction extends AbstractAction {
 
        private GridView view;
 
-       public PlayCustomGridAction(JFrame parent, String text, Icon icon,
+       public PlayCustomGridAction(String text, Icon icon,
                        String desc, Integer mnemonic, GridView view) {
                super(text, icon);
                
index 17d790e..2f4316b 100644 (file)
@@ -45,7 +45,7 @@ public class ResolveAction extends AbstractAction {
 
        @Override
        public void actionPerformed(ActionEvent e) {
-               ResolveGridDialog dlg = new ResolveGridDialog(frame, view, this);
+               ResolveGridDialog dlg = new ResolveGridDialog(frame, view);
                dlg.setVisible(true);
                int result = dlg.getResult();
                if (result == 0) {
index 34d1626..9ad3995 100644 (file)
@@ -54,8 +54,7 @@ public class ResolveGridDialog extends JDialog {
        private final BruteForceGridSolver bruteSolver;\r
        private final GridModel gridToSolve;\r
 \r
-       public ResolveGridDialog(JFrame parent, final GridView view,\r
-                       final ResolveAction resolveAction) {\r
+       public ResolveGridDialog(JFrame parent, final GridView view) {\r
 \r
                super(parent, true);\r
                this.parent = parent;\r
@@ -85,7 +84,7 @@ public class ResolveGridDialog extends JDialog {
                        /* Executed in the EDT, triggered when the SwingWorker has completed */\r
                        protected void done() {\r
                                try {\r
-                                       status = get();\r
+                                       status = get().intValue();\r
                                } catch (InterruptedException e) {\r
                                        e.printStackTrace();\r
                                        return;\r
@@ -154,14 +153,14 @@ public class ResolveGridDialog extends JDialog {
                return status;\r
        }\r
 \r
-       private int resolveGrid() {\r
+       private Integer resolveGrid() {\r
 \r
                GridSolution solution = bruteSolver.resolve();\r
                if (solution == null) {\r
                        /**\r
                         * RESOLUTION PROCESS CANCELLED BEFORE COMPLETION\r
                         */\r
-                       return 1;\r
+                       return Integer.valueOf(1);\r
                }\r
                if (solution.isSolved()) {\r
                        GridModel solGrid = solution.getSolutionGrid();\r
@@ -175,12 +174,12 @@ public class ResolveGridDialog extends JDialog {
                        /**\r
                         * RESOLUTION SUCCESSFULL\r
                         */\r
-                       return 0;\r
+                       return Integer.valueOf(0);\r
                } else {\r
                        /**\r
                         * RESOLUTION PROCESS WAS UNABLE TO SOLVE THIS GRID\r
                         */\r
-                       return 2;\r
+                       return Integer.valueOf(2);\r
                }\r
        }\r
 \r
index 80de37e..cc00e9a 100644 (file)
@@ -22,7 +22,7 @@ public class SaveAsAction extends AbstractAction {
        private final GridView view;
        private final JFrame frame;
 
-       SaveAsAction(JFrame frame, GridView view, ActionsRepository actions) {
+       SaveAsAction(JFrame frame, GridView view) {
                this.frame = frame;
                this.view = view;
        }
index b2072a8..1db1a5b 100644 (file)
@@ -139,7 +139,7 @@ public class SelectMemosPanel extends JPanel {
 
                Iterator<Byte> it = memos.iterator();
                while (it.hasNext()) {
-                       JToggleButton button = ckb[it.next()-1];
+                       JToggleButton button = ckb[it.next().intValue()-1];
                        button.setSelected(true);
                        button.setFont(BOLD_FONT);
                }
@@ -177,10 +177,10 @@ public class SelectMemosPanel extends JPanel {
        private void buttonClicked(int button) {
                byte value = (byte)(button + 1);
                if (ckb[button].isSelected()) {
-                       memos.add(value);
+                       memos.add(Byte.valueOf(value));
                        ckb[button].setFont(BOLD_FONT);
                } else {
-                       memos.remove(value);
+                       memos.remove(Byte.valueOf(value));
                        ckb[button].setFont(NORMAL_FONT);
                }
        }
@@ -191,7 +191,7 @@ public class SelectMemosPanel extends JPanel {
                Iterator<Byte> it = memos.iterator();
                int i = 0;
                while (it.hasNext()) {
-                       memosArray[i] = it.next();
+                       memosArray[i] = it.next().byteValue();
                        i++;
                }
                return memosArray;
index 40edabe..390057a 100644 (file)
@@ -21,7 +21,6 @@ import java.awt.event.ActionEvent;
 \r
 import javax.swing.AbstractAction;\r
 import javax.swing.Icon;\r
-import javax.swing.JFrame;\r
 \r
 import net.jankenpoi.sudokuki.view.GridView;\r
 \r
@@ -30,7 +29,7 @@ public class SetAllMemosAction extends AbstractAction {
 \r
        private GridView view;\r
 \r
-       public SetAllMemosAction(JFrame parent, String text, Icon icon,\r
+       public SetAllMemosAction(String text, Icon icon,\r
                        String desc, Integer mnemonic, GridView view) {\r
                super(text, icon);\r
                \r
index f688e63..449c132 100644 (file)
@@ -21,7 +21,6 @@ import java.awt.event.ActionEvent;
 \r
 import javax.swing.AbstractAction;\r
 import javax.swing.Icon;\r
-import javax.swing.JFrame;\r
 \r
 import net.jankenpoi.sudokuki.view.GridView;\r
 \r
@@ -30,7 +29,7 @@ public class SetMemosHereAction extends AbstractAction {
 \r
        private GridView view;\r
 \r
-       public SetMemosHereAction(JFrame parent, String text, Icon icon,\r
+       public SetMemosHereAction(String text, Icon icon,\r
                        String desc, Integer mnemonic, GridView view) {\r
                super(text, icon);\r
                \r
index 447333a..fcc628f 100644 (file)
@@ -55,7 +55,7 @@ public abstract class GridView implements GridListener {
 
        public boolean isCellValueSet(int li, int co) {
                for (byte v = 1; v<=9; v++) {
-                       if (isCellValueSet(li, co, v)) {
+                       if (isCellValueSet(li, co, Byte.valueOf(v))) {
                                return true;
                        }
                }