OSDN Git Service

dma-mapping: fix flags in dma_alloc_wc
authorChristoph Hellwig <hch@lst.de>
Sat, 22 Dec 2018 08:21:08 +0000 (09:21 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 22 Dec 2018 16:46:27 +0000 (08:46 -0800)
We really need the writecombine flag in dma_alloc_wc, fix a stupid
oversight.

Fixes: 7ed1d91a9e ("dma-mapping: translate __GFP_NOFAIL to DMA_ATTR_NO_WARN")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/dma-mapping.h

index 15bd414..d327bdd 100644 (file)
@@ -796,7 +796,7 @@ static inline void dmam_release_declared_memory(struct device *dev)
 static inline void *dma_alloc_wc(struct device *dev, size_t size,
                                 dma_addr_t *dma_addr, gfp_t gfp)
 {
-       unsigned long attrs = DMA_ATTR_NO_WARN;
+       unsigned long attrs = DMA_ATTR_WRITE_COMBINE;
 
        if (gfp & __GFP_NOWARN)
                attrs |= DMA_ATTR_NO_WARN;