OSDN Git Service

pNFS: Fix RCU lock leakage
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Sat, 11 Apr 2020 15:37:18 +0000 (11:37 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Sat, 11 Apr 2020 15:42:35 +0000 (11:42 -0400)
Another brown paper bag moment. pnfs_alloc_ds_commits_list() is leaking
the RCU lock.

Fixes: a9901899b649 ("pNFS: Add infrastructure for cleaning up per-layout commit structures")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/pnfs_nfs.c

index 25f1355..e7ddbce 100644 (file)
@@ -501,6 +501,7 @@ pnfs_alloc_ds_commits_list(struct list_head *list,
                rcu_read_lock();
                pnfs_put_commit_array(array, cinfo->inode);
        }
+       rcu_read_unlock();
        return ret;
 }