OSDN Git Service

irqchip/gic-v4.1: Skip absent CPUs while iterating over redistributors
authorMarc Zyngier <maz@kernel.org>
Wed, 4 Mar 2020 20:33:09 +0000 (20:33 +0000)
committerMarc Zyngier <maz@kernel.org>
Thu, 19 Mar 2020 11:21:58 +0000 (11:21 +0000)
In a system that is only sparsly populated with CPUs, we can end-up with
redistributors structures that are not initialized. Let's make sure we
don't try and access those when iterating over them (in this case when
checking we have a L2 VPE table).

Fixes: 4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Link: https://lore.kernel.org/r/20200304203330.4967-3-maz@kernel.org
drivers/irqchip/irq-gic-v3-its.c

index 83b1186..da883a6 100644 (file)
@@ -2452,6 +2452,10 @@ static bool allocate_vpe_l2_table(int cpu, u32 id)
        if (!gic_rdists->has_rvpeid)
                return true;
 
+       /* Skip non-present CPUs */
+       if (!base)
+               return true;
+
        val  = gicr_read_vpropbaser(base + SZ_128K + GICR_VPROPBASER);
 
        esz  = FIELD_GET(GICR_VPROPBASER_4_1_ENTRY_SIZE, val) + 1;