OSDN Git Service

rtc: rv3029: simplify rv3029_set_alarm
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 14 Dec 2019 22:10:14 +0000 (23:10 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 18 Dec 2019 09:37:59 +0000 (10:37 +0100)
It is unecessay to test alarm->enabled before calling
rv3029_alarm_irq_enable.

Link: https://lore.kernel.org/r/20191214221022.622482-9-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-rv3029c2.c

index 631e4a9..2d12d13 100644 (file)
@@ -440,19 +440,7 @@ static int rv3029_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
        if (ret < 0)
                return ret;
 
-       if (alarm->enabled) {
-               /* enable AIE irq */
-               ret = rv3029_alarm_irq_enable(dev, 1);
-               if (ret)
-                       return ret;
-       } else {
-               /* disable AIE irq */
-               ret = rv3029_alarm_irq_enable(dev, 0);
-               if (ret)
-                       return ret;
-       }
-
-       return 0;
+       return rv3029_alarm_irq_enable(dev, alarm->enabled);
 }
 
 static int rv3029_set_time(struct device *dev, struct rtc_time *tm)