OSDN Git Service

crypto: artpec6 - return correct error code for failed setkey()
authorEric Biggers <ebiggers@google.com>
Tue, 31 Dec 2019 03:19:32 +0000 (21:19 -0600)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 9 Jan 2020 03:30:51 +0000 (11:30 +0800)
->setkey() is supposed to retun -EINVAL for invalid key lengths, not -1.

Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver")
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Lars Persson <lars.persson@axis.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Lars Persson <lars.persson@axis.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/axis/artpec6_crypto.c

index 4b20606..22ebe40 100644 (file)
@@ -1251,7 +1251,7 @@ static int artpec6_crypto_aead_set_key(struct crypto_aead *tfm, const u8 *key,
 
        if (len != 16 && len != 24 && len != 32) {
                crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN);
-               return -1;
+               return -EINVAL;
        }
 
        ctx->key_length = len;