OSDN Git Service

crypto: amcc - remove incorrect __init/__exit markups
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 9 Mar 2015 20:35:39 +0000 (13:35 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 11 Mar 2015 14:11:07 +0000 (01:11 +1100)
Even if bus is not hot-pluggable, the devices can be bound and unbound
from the driver via sysfs, so we should not be using __init/__exit
annotations on probe() and remove() methods. The only exception is
drivers registered with platform_driver_probe() which specifically
disables sysfs bind/unbind attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/amcc/crypto4xx_core.c

index d02b771..3b28e8c 100644 (file)
@@ -1155,7 +1155,7 @@ struct crypto4xx_alg_common crypto4xx_alg[] = {
 /**
  * Module Initialization Routine
  */
-static int __init crypto4xx_probe(struct platform_device *ofdev)
+static int crypto4xx_probe(struct platform_device *ofdev)
 {
        int rc;
        struct resource res;
@@ -1263,7 +1263,7 @@ err_alloc_dev:
        return rc;
 }
 
-static int __exit crypto4xx_remove(struct platform_device *ofdev)
+static int crypto4xx_remove(struct platform_device *ofdev)
 {
        struct device *dev = &ofdev->dev;
        struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev);
@@ -1291,7 +1291,7 @@ static struct platform_driver crypto4xx_driver = {
                .of_match_table = crypto4xx_match,
        },
        .probe          = crypto4xx_probe,
-       .remove         = __exit_p(crypto4xx_remove),
+       .remove         = crypto4xx_remove,
 };
 
 module_platform_driver(crypto4xx_driver);