OSDN Git Service

net/smc: fix a memory leak in smc_sysctl_net_exit()
authorEric Dumazet <edumazet@google.com>
Fri, 25 Mar 2022 16:50:21 +0000 (09:50 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 26 Mar 2022 21:17:01 +0000 (14:17 -0700)
Recently added smc_sysctl_net_exit() forgot to free
the memory allocated from smc_sysctl_net_init()
for non initial network namespace.

Fixes: 462791bbfa35 ("net/smc: add sysctl interface for SMC")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: Tony Lu <tonylu@linux.alibaba.com>
Cc: Dust Li <dust.li@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/smc/smc_sysctl.c

index bae1941..cf3ab13 100644 (file)
@@ -61,5 +61,10 @@ err_alloc:
 
 void __net_exit smc_sysctl_net_exit(struct net *net)
 {
+       struct ctl_table *table;
+
+       table = net->smc.smc_hdr->ctl_table_arg;
        unregister_net_sysctl_table(net->smc.smc_hdr);
+       if (!net_eq(net, &init_net))
+               kfree(table);
 }