OSDN Git Service

net: hns3: add max order judgement for tx spare buffer
authorHao Chen <chenhao288@hisilicon.com>
Sat, 26 Mar 2022 09:51:01 +0000 (17:51 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 26 Mar 2022 16:16:49 +0000 (09:16 -0700)
Add max order judgement for tx spare buffer to avoid triggering
call trace, print related fail information instead, when user
set tx spare buf size to a large value which causes order
exceeding 10.

Fixes: e445f08af2b1 ("net: hns3: add support to set/get tx copybreak buf size via ethtool for hns3 driver")
Signed-off-by: Hao Chen <chenhao288@hisilicon.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

index 1613723..530ba8b 100644 (file)
@@ -1038,6 +1038,12 @@ static void hns3_init_tx_spare_buffer(struct hns3_enet_ring *ring)
                return;
 
        order = get_order(alloc_size);
+       if (order >= MAX_ORDER) {
+               if (net_ratelimit())
+                       dev_warn(ring_to_dev(ring), "failed to allocate tx spare buffer, exceed to max order\n");
+               return;
+       }
+
        tx_spare = devm_kzalloc(ring_to_dev(ring), sizeof(*tx_spare),
                                GFP_KERNEL);
        if (!tx_spare) {