Cppcheck: CWE: 398: Parameter 'events' is passed by value. It could be passed as...

diff --git a/Src/MainFrm.cpp b/Src/MainFrm.cpp
index 4c27605..84580d8 100644 (file)
--- a/Src/MainFrm.cpp
+++ b/Src/MainFrm.cpp
@@ -2889,7 +2889,7 @@ void CMainFrame::ReloadMenu()
 }
 
 void CMainFrame::AppendPluginMenus(CMenu *pMenu, const String& filteredFilenames,
-       const std::vector<std::wstring> events, bool addAllMenu, unsigned baseId)
+       const std::vector<std::wstring>& events, bool addAllMenu, unsigned baseId)
 {
        if (!GetOptionsMgr()->GetBool(OPT_PLUGINS_ENABLED))
                return;
@@ -2956,7 +2956,7 @@ void CMainFrame::AppendPluginMenus(CMenu *pMenu, const String& filteredFilenames
        popupAll.Detach();
 }
 
-String CMainFrame::GetPluginPipelineByMenuId(unsigned idSearch, const std::vector<std::wstring> events, unsigned baseId)
+String CMainFrame::GetPluginPipelineByMenuId(unsigned idSearch, const std::vector<std::wstring>& events, unsigned baseId)
 {
        PluginInfo* pluginFound = nullptr;
        auto [suggestedPlugins, allPlugins] = FileTransform::CreatePluginMenuInfos(_T(""), events, baseId);

diff --git a/Src/MainFrm.h b/Src/MainFrm.h
index 8063201..95e098f 100644 (file)
--- a/Src/MainFrm.h
+++ b/Src/MainFrm.h
@@ -126,8 +126,8 @@ public:
        static void UpdateDocTitle();
        static void ReloadMenu();
        static void AppendPluginMenus(CMenu* pMenu, const String& filteredFilenames,
-               const std::vector<std::wstring> events, bool addAllMenu, unsigned baseId);
-       static String GetPluginPipelineByMenuId(unsigned idSearch, const std::vector<std::wstring> events, unsigned baseId);
+               const std::vector<std::wstring>& events, bool addAllMenu, unsigned baseId);
+       static String GetPluginPipelineByMenuId(unsigned idSearch, const std::vector<std::wstring>& events, unsigned baseId);
        DropHandler *GetDropHandler() const { return m_pDropHandler; }
        const CTypedPtrArray<CPtrArray, CMDIChildWnd*>* GetChildArray() const { return &m_arrChild; }
        IMergeDoc* GetActiveIMergeDoc();