Fix new mined orphan block broadcast bug (#1592)

* Fix new mined orphan block broadcast bug

* fix review bug

diff --git a/netsync/block_fetcher.go b/netsync/block_fetcher.go
index 7ef4be5..8baa33a 100644 (file)
--- a/netsync/block_fetcher.go
+++ b/netsync/block_fetcher.go
@@ -73,7 +73,8 @@ func (f *blockFetcher) add(msg *blockMsg) {
 }
 
 func (f *blockFetcher) insert(msg *blockMsg) {
-       if _, err := f.chain.ProcessBlock(msg.block); err != nil {
+       isOrphan, err := f.chain.ProcessBlock(msg.block)
+       if err != nil {
                peer := f.peers.getPeer(msg.peerID)
                if peer == nil {
                        return
@@ -83,6 +84,10 @@ func (f *blockFetcher) insert(msg *blockMsg) {
                return
        }
 
+       if isOrphan {
+               return
+       }
+
        if err := f.peers.broadcastMinedBlock(msg.block); err != nil {
                log.WithFields(log.Fields{"module": logModule, "err": err}).Error("blockFetcher fail on broadcast new block")
                return