OSDN Git Service
Geoff Mendal [Wed, 29 Jul 2015 15:45:30 +0000 (15:45 +0000)]
am
a94d0f6f: (-s ours) Import translations. DO NOT MERGE
* commit '
a94d0f6f8f74a3d0b24cf31641d036cff59f8579':
Import translations. DO NOT MERGE
Geoff Mendal [Wed, 29 Jul 2015 15:04:52 +0000 (08:04 -0700)]
Import translations. DO NOT MERGE
Change-Id: Ib6a5d3ad23b3b1f6490853959ee68c2d667817b0
Auto-generated-cl: translation import
Geoff Mendal [Wed, 29 Jul 2015 15:03:53 +0000 (08:03 -0700)]
Import translations. DO NOT MERGE
Change-Id: Ibca60d6b4cced483ee7ec106ec45c1fbdd50a02c
Auto-generated-cl: translation import
Alan Newberger [Fri, 24 Jul 2015 17:57:56 +0000 (10:57 -0700)]
Remove unused ACCOUNTS permissions
BUG=
22716720
Change-Id: Id465f3cf55f41d7ebf90e4feecfa38824b66faa4
Alan Newberger [Fri, 24 Jul 2015 17:47:55 +0000 (10:47 -0700)]
Protect against destroying uncreated values
Though we attempt to minimize lifecycle impact by exiting onCreate
early due to inadequate permissions, we need to protect against
touching fields in onDestroy that we did not initialize in onCreate.
BUG=
22718094
Change-Id: I49adcbbed005c4efa785458aa398e61488cfceb0
Sascha Haeberling [Wed, 22 Jul 2015 23:52:31 +0000 (16:52 -0700)]
[Haleakala] Change JPEG compression thread priority to BACKGROUND - 1.
Bug:
22670310
Change-Id: Ic2ee7e2de141d7df2a316733b465daa354b2d517
zafir [Wed, 15 Jul 2015 08:14:10 +0000 (01:14 -0700)]
Fixes to M permissions.
Previously, we called PermissionsActivity with startActivityForResult().
However, this creates race conditions as we check for permissions
and the CameraActivity continues to operate. Now, we end CameraActivity
and launch a new instance upon successful permissions resolution.
We can also put the preload filmstrip logic back in its original
place in onCreate. The checks for permissions happen in both
onCreate and onResume.
Bug:
22442745,
22478144,
22497152
Change-Id: I82e9125a46581db44aa61d4ee94aec5a820e9df0
zafir [Wed, 15 Jul 2015 08:14:10 +0000 (01:14 -0700)]
Camera M permissions: lockscreen improvements
This CL now just provides some improvements for lockscreen independent
of any onCreate/onResume lifecycle adjustments. Fixes include:
* add a black content view to Permissions Activity -- noticed screen
junk opening from lockscreen due to unpainted regions, the whole
activity needs to paint the screen not just the dialog.
* use FLAG_SHOW_WHEN_LOCKED to show permissions screen over lockscreen,
per bug discussion in this case force failure, don't prompt for
permission grants.
* fun double onResumes induce flicker jank in the dialog UI. Inherit
QuickActivity to automatically pick up the workarounds for double
onResumes from lockscreens, no more flicker in the permission
dialog.
* also borrow from CameraActivity, broadcast receives to shut down
the permissions dialog when screen goes off or user hits home on
top of lockscreen. Actually apply this more broadly so that even
below lockscreen, we finish this activity on screen off, IMO it
is jarring to go in through lockscreen and see our permission
dialog again without context of having just opened camera.
* tweak permission dialog to not be cancelable, and to finish
activity on back button press.
* excludeFromRecents on the activity to prevent dual recents
for Camera to show up when opening both via SecureCameraActivity
and CameraActivity.
Bug:
22502696
Change-Id: Ib545d3baa2d83b52604eec5517047b0c6278cd92
Geoff Mendal [Wed, 15 Jul 2015 14:06:56 +0000 (14:06 +0000)]
am
36c35f23: (-s ours) Import translations. DO NOT MERGE
* commit '
36c35f23f17ecfc47d1e2ef5d36b6516251b9018':
Import translations. DO NOT MERGE
Geoff Mendal [Wed, 15 Jul 2015 13:53:21 +0000 (06:53 -0700)]
Import translations. DO NOT MERGE
Change-Id: I53f7a9c9bbdcdde5cad99311baab64f6f544d166
Auto-generated-cl: translation import
Geoff Mendal [Wed, 15 Jul 2015 13:52:21 +0000 (06:52 -0700)]
Import translations. DO NOT MERGE
Change-Id: I6dcf9bc38b2598177be02909f1f856ffc27cc609
Auto-generated-cl: translation import
Geoff Mendal [Tue, 14 Jul 2015 21:06:00 +0000 (21:06 +0000)]
am
ec5a5213: (-s ours) Import translations. DO NOT MERGE
* commit '
ec5a52136e344305fac60f6053fe4c36aa24ceb8':
Import translations. DO NOT MERGE
Geoff Mendal [Tue, 14 Jul 2015 20:46:35 +0000 (13:46 -0700)]
Import translations. DO NOT MERGE
Change-Id: I98a926452e577686aa0fa16232c7e25a6a8ba234
Auto-generated-cl: translation import
Geoff Mendal [Tue, 14 Jul 2015 20:40:25 +0000 (13:40 -0700)]
Import translations. DO NOT MERGE
Change-Id: Ic68870870e0b7c0b89c4dad2cecf0981ae6086fc
Auto-generated-cl: translation import
Alan Newberger [Mon, 13 Jul 2015 16:25:21 +0000 (16:25 +0000)]
am
ad510fdd: Merge "Set ModeListView to LTR layout" into ub-camera-haleakala
* commit '
ad510fddb124d1e02fd1e135d672ab1f14923e56':
Set ModeListView to LTR layout
Alan Newberger [Mon, 13 Jul 2015 16:17:35 +0000 (16:17 +0000)]
Merge "Set ModeListView to LTR layout" into ub-camera-haleakala
Geoff Mendal [Mon, 13 Jul 2015 12:47:42 +0000 (12:47 +0000)]
am
1ac1ac74: (-s ours) Import translations. DO NOT MERGE
* commit '
1ac1ac74af7007eb7351eb60c832e1f405252f34':
Import translations. DO NOT MERGE
Geoff Mendal [Mon, 13 Jul 2015 12:20:38 +0000 (05:20 -0700)]
Import translations. DO NOT MERGE
Change-Id: Idd4712a71746b45c1512f75c8d1062513acb3a6a
Auto-generated-cl: translation import
Geoff Mendal [Mon, 13 Jul 2015 12:19:38 +0000 (05:19 -0700)]
Import translations. DO NOT MERGE
Change-Id: I3b7e6493447bb1c23aa65ab3dd326d51210b2256
Auto-generated-cl: translation import
Geoff Mendal [Sat, 11 Jul 2015 12:34:51 +0000 (12:34 +0000)]
am
b980a5be: (-s ours) Import translations. DO NOT MERGE
* commit '
b980a5be2ea0d39d99e4946885278efbfaf1bf37':
Import translations. DO NOT MERGE
Geoff Mendal [Sat, 11 Jul 2015 12:26:23 +0000 (05:26 -0700)]
Import translations. DO NOT MERGE
Change-Id: I29df25340044638daaed9d2fd7828b85af0eef86
Auto-generated-cl: translation import
Geoff Mendal [Sat, 11 Jul 2015 12:25:19 +0000 (05:25 -0700)]
Import translations. DO NOT MERGE
Change-Id: If81760a295e909e517fe103cdd0fbe014d647dc5
Auto-generated-cl: translation import
Alan Newberger [Sat, 11 Jul 2015 01:22:20 +0000 (18:22 -0700)]
Set ModeListView to LTR layout
Mode list is LTR layout at all times. But without being marked as
such, subitems like SettingsCling had their getLeft View property
adjusted for RTL layout. SettingsCling had a ~800 pixel left
property under RTL vs 0 in LTR, causing it to set itself off
screen.
BUG=
22206761
Change-Id: I356e464a1121069def71c350902c032833542c29
Alan Newberger [Sat, 11 Jul 2015 00:28:45 +0000 (00:28 +0000)]
am
e25f675a: Shorten location startup dialog string
* commit '
e25f675a189f56df57d08b62fa3604843dfee4a8':
Shorten location startup dialog string
Alan Newberger [Fri, 10 Jul 2015 23:46:40 +0000 (16:46 -0700)]
Shorten location startup dialog string
BUG=
21706101
Change-Id: I66164d43830cb71bb3a24f0f996a533358cb7d7e
Alan Newberger [Fri, 10 Jul 2015 16:48:42 +0000 (16:48 +0000)]
am
00720781: Null check when evaluating valid resolution size
* commit '
00720781f6703de532ddbc05238db5bf5fd7cd2d':
Null check when evaluating valid resolution size
Alan Newberger [Fri, 10 Jul 2015 16:39:13 +0000 (09:39 -0700)]
Null check when evaluating valid resolution size
Guard against nonexistent size so that logic to reset size
preference can proceed
BUG=
22396405
Change-Id: Id508713ef91f632867366934e72fe939a839e228
zafir [Wed, 8 Jul 2015 23:12:02 +0000 (16:12 -0700)]
Launch PermissionsActivity if CameraActivity resume is called without critical permissions.
Bug:
22358833
Change-Id: I5c189d4976b9355d531e028ecc163bb67bae6987
Alan Newberger [Wed, 8 Jul 2015 19:42:04 +0000 (12:42 -0700)]
Clear permissions check after successful PermissionsActivity
If the permissions activity indicates the user was successful,
mark mHasCriticalPermissions true to allow the app to resume normally.
BUG=
22347017
Change-Id: I6b9bdd02382d071530529a08e8f8fe7faf02fe3b
Alan Newberger [Wed, 8 Jul 2015 16:51:04 +0000 (09:51 -0700)]
Restrict permission checks to M devices
Add an ApiHelper check and only call checkSelfPermission if we
are on M and the methods exist.
BUG=
22345681
Change-Id: Icda8d40057b5492502858ced731a749a2f66abf8
Geoff Mendal [Wed, 8 Jul 2015 13:02:29 +0000 (06:02 -0700)]
Import translations. DO NOT MERGE
Change-Id: I3e278d51be24e50c7b97e94929914bb982ff1ebe
Auto-generated-cl: translation import
zafir [Mon, 29 Jun 2015 05:08:22 +0000 (00:08 -0500)]
Minimum viable Android M runtime permissions handling for H.
Creates new activity for permissions handling: both checking
for permissions and handling error condition when critical
permissions are not present. The reason for creating a
new activity is so the app does not attempt to continue
executing OnCreate, OnResume etc, which opens
the camera while the dialogs are showing. This should
not slow the app down because the permissions activity
will only run when a) the first time the app has
insufficient permissions and b) when a critical
permission is missing and the app needs to shut down.
Bug:
21273463
Change-Id: I603acfb3057ba26b9cfa7935eb4cb24b5d547cb5
Alan Newberger [Mon, 29 Jun 2015 17:49:25 +0000 (17:49 +0000)]
Merge "Ensure CaptureModule/API2 works without front camera" into ub-camera-haleakala
Alan Newberger [Mon, 29 Jun 2015 17:32:35 +0000 (17:32 +0000)]
Merge "Update filmstrip item on metadata update" into ub-camera-haleakala
Alan Newberger [Thu, 25 Jun 2015 20:58:33 +0000 (13:58 -0700)]
Ensure CaptureModule/API2 works without front camera
Add a check in both first run dialogs, and the generated HardwareSpec,
so that front cameras are only used if detected.
BUG=
21781461
Change-Id: I6844655b2fd3df90b649f5dfd6a006ef68dbf1da
Alan Newberger [Thu, 25 Jun 2015 18:40:32 +0000 (11:40 -0700)]
Update filmstrip item on metadata update
Due to async metadata loading, when viewing an image progress bar,
after progress completion the main handler hiding progress bar would
also hide filmstrip buttons if in secure mode, but the async metadata
handler was calling a restricted handler that would only update the
controls, not hiding for secure, or updating overflow menu. This
change ensures all UI aspects of the item update are processed upon
metadata loading.
BUG=
21499182
Change-Id: I92f22667d836d6ece6aa8427d967ec8e038b1e77
Senpo Hu [Thu, 25 Jun 2015 17:32:49 +0000 (17:32 +0000)]
Merge "Fix transform issue in CaptureIntent." into ub-camera-haleakala
Senpo Hu [Fri, 12 Jun 2015 23:20:46 +0000 (16:20 -0700)]
Fix transform issue in CaptureIntent.
On M, EventOnTextureViewLayoutChanged comes earlier during app
initialization in StateForeground which doesn't handle it. So
here in StateReadyForCapture, we pull the current preview layout
size and inform ResourceSurfaceTexture to allow it to calculate
transform.
Noted that we also need to bring this fix to Ivvavik.
Bug:
21786937
Bug:
20173626
Change-Id: I417aef2f09247e77059fc5b066cbf10602ce5cf1
Geoff Mendal [Tue, 16 Jun 2015 14:26:13 +0000 (07:26 -0700)]
Import translations. DO NOT MERGE
Change-Id: I68480e5a35383d6967dedbada17bc8075a24d90e
Auto-generated-cl: translation import
I-Jong Lin [Thu, 11 Jun 2015 00:10:30 +0000 (17:10 -0700)]
Fix for invalidated resolutions via upgrade
Bug:
21758681
There was a upgrade bug where an valid resolution of the
previous version of the Camera App could then be invalidated
the subsequent version of the Camera App. If there were no
other valid resolutions of the same aspect ratio available
to the app, the current Camera App would choose (0,0) as its
default size and then write this value into the saved settings.
This fix allows the current Camera App to consider other resolutions
not of aspect ratio as a fallback resolution setting. Also, if
an invalid resolution valid has been saved to the settings, it
also ignores it and then resaves a valid resolution value to the
settings.
Change-Id: I08f19d1ee6491619e92697897b73e4fd33a19a00
I-Jong Lin [Mon, 8 Jun 2015 19:24:51 +0000 (12:24 -0700)]
Refresh required for full-screen undo in filmstrip
Bug:
21666018
A Glacier regression bug: when filmstrip is in full-screen mode,
and an deletion is undone, a blank screen is shown. With the fix,
the undo forces the filmstrip into its "filmstrip" mode and
forces a refresh with the un-deleted image.
Change-Id: Id99be5d4d06e220e8698821badff32dba9b43997
Geoff Mendal [Mon, 8 Jun 2015 12:36:01 +0000 (05:36 -0700)]
Import translations. DO NOT MERGE
Change-Id: Ia8c1a4f5d0fdc4d89b6b817da959888d1916aac0
Auto-generated-cl: translation import
Geoff Mendal [Wed, 3 Jun 2015 16:20:51 +0000 (09:20 -0700)]
Import translations. DO NOT MERGE
Change-Id: I1f299766739dbf1ed6fa34340cdca5dbea1f6837
Auto-generated-cl: translation import
Geoff Mendal [Mon, 1 Jun 2015 13:07:40 +0000 (06:07 -0700)]
Import translations. DO NOT MERGE
Change-Id: I9e3eba897019de07aefe4b661040453808a94de9
Auto-generated-cl: translation import
Geoff Mendal [Sat, 30 May 2015 16:15:38 +0000 (09:15 -0700)]
Import translations. DO NOT MERGE
Change-Id: I85d8e4593585d2af00fd20b7e1ec65630b8476b0
Auto-generated-cl: translation import
Sascha Haeberling [Fri, 29 May 2015 23:20:28 +0000 (16:20 -0700)]
Use Google Feedback CrashBuilder API to make reports easier to consume.
Manual Cherry-Pick Part 1 of http://ag/699672
Currently, Feedback reports don't include a stacktrace. You have to
download
a system log file to find it. This tweak allows us to see the stacktrace
on the Report page itself.
Example old report:
https://feedback.corp.google.com/product/102042/crash?lView=rd&lCategory=
8590053278&lRSort=1&lROrder=2&lRFilter=1&lReport=
5517267704
Example new report:
https://feedback.corp.google.com/product/102042/crash?lView=rd&lCategory=
8590053278&lRSort=1&lROrder=2&lRFilter=1&lReport=
5517601160
Change-Id: If5f0ed6c69e96fe5f3661af913ae1525f8594b75
Gabriel Nava [Thu, 28 May 2015 16:36:23 +0000 (09:36 -0700)]
Fix for unusable camera after quick pause/resume and HDR+ switch (camera-Haleakala)
- Removing the hack for b/
18854352
- Running the camera reopen camera operations and onReadyForCapture callback in a non-UI thread to avoid dead-locks
Bug:
21025113
Change-Id: I5545148769d92e5a87ffa9b693397fd7737edee6
Sascha Haeberling [Thu, 28 May 2015 00:04:28 +0000 (17:04 -0700)]
Add logging for when a session knowingly failed.
Bug:
21169512
Change-Id: Ic1dc499785a97f7344e517f555fa5f7b3a1c7ea9
Paul Rohde [Wed, 27 May 2015 23:36:28 +0000 (23:36 +0000)]
Merge "Log capture session canceled events." into ub-camera-haleakala
Paul Rohde [Wed, 27 May 2015 22:14:59 +0000 (15:14 -0700)]
Log capture session canceled events.
This will handle the edgecase where capture sessions may be
canceled inbetween the time the button is pressed and the capture
actually starts so that it is possible to subtract these cases
out of the unsaved image data.
Bug:
21169512
Change-Id: Ie226d81bb10acd90dc1297230d4b024b7cd2d4d6
Gabriel Nava [Wed, 27 May 2015 17:42:03 +0000 (10:42 -0700)]
Handling the GcamService timeout due to application in paused state (camera-Haleakala)
- When GcamService times out due to a pause state, all resources are released.
- Releasing the gcam resources without showing the error dialog allows next resume operation to open the camera
Bug:
21025113
Change-Id: I95a89fbf6ce2498c1323cd4d06383141cc7cb913
Geoff Mendal [Thu, 21 May 2015 13:42:33 +0000 (06:42 -0700)]
Import translations. DO NOT MERGE
Change-Id: I3f56ffd3cd032a6c6c1984c6a5c0648733a748b2
Auto-generated-cl: translation import
Spike Sprague [Wed, 20 May 2015 02:03:23 +0000 (19:03 -0700)]
Fill out more EXIF data, closer parity to Nexus HAL
bug:
21277434
Change-Id: I4e4d9b4bffa6b0a8ccb3e870d553643dd27d2356
Sascha Haeberling [Wed, 20 May 2015 21:54:13 +0000 (21:54 +0000)]
Merge "Don't attempt to update thumbnail if session is finished." into ub-camera-haleakala
Sascha Haeberling [Wed, 20 May 2015 21:41:53 +0000 (14:41 -0700)]
Don't attempt to update thumbnail if session is finished.
Bug:
21167342
Change-Id: If2e4db523aa66e82809d30aa35fb9a30d124d9df
Gabriel Nava [Wed, 20 May 2015 19:39:02 +0000 (12:39 -0700)]
Fix to avoid random ArrayIndexOutOfBoundsException in bottom bar (camera-Haleakala)
Bug:
20957536
Change-Id: I6985d009e550f8f67ff36be3fce53c82ada0610e
Paul Rohde [Wed, 20 May 2015 18:43:37 +0000 (18:43 +0000)]
Merge "Log capture started and bytes on disk" into ub-camera-haleakala
Paul Rohde [Fri, 15 May 2015 22:29:26 +0000 (15:29 -0700)]
Log capture started and bytes on disk
Change-Id: I3a62aed33f55b396b4940a7bc9e5da5131616890
Paul Rohde [Mon, 18 May 2015 18:27:40 +0000 (11:27 -0700)]
Make filmstrip grey squares less common.
Increase the encoding priority of the intermediate thumbnails
by changing the task priority to "Average". This causes the
intermediate thumbs to run on their own thread pool, after
the tiny thumbs are generated but allow them to not get
prempted by slow, full jpg encoding tasks.
Bug:
21169512
Change-Id: I2862acac724cf6302c896feeeb04702170cbf030
Pengchong Jin [Fri, 15 May 2015 23:12:21 +0000 (23:12 +0000)]
Merge "Workaround of the face detection failure on L and N5" into ub-camera-haleakala
Paul Rohde [Fri, 15 May 2015 22:55:21 +0000 (22:55 +0000)]
Merge "Increase the default JPG buffer size." into ub-camera-haleakala
Paul Rohde [Fri, 15 May 2015 22:30:13 +0000 (15:30 -0700)]
Increase the default JPG buffer size.
BUG:
21162720
Change-Id: Ie9d634533778c254a000da92f0af2948d814b1dd
Alan Newberger [Fri, 15 May 2015 22:05:00 +0000 (15:05 -0700)]
Dynamic configuration management for Camera2
Ensure Camera2 app selects the appropriate OneCamera per
feature configuration.
Bug:
21204365
Change-Id: I47671a91c89f20e2add2f1f3889d4411341fa1dc
Pengchong Jin [Fri, 15 May 2015 20:07:10 +0000 (13:07 -0700)]
Workaround of the face detection failure on L and N5
This patch is a workaround of the face detection failure on L
and Nexus 5. For Nexus 5 on L, the current FD only works when
the preview stream is configured as the first stream before the
JPEG stream. This change lock the order by creating a capture
session with the preview stream first, and then creating the
normal capture session with preview and JPEG.
Bug: b/
21039466
Change-Id: Icb7f1f758bc9d7ca428c7a4748223072d39dd57f
Alan Newberger [Thu, 14 May 2015 23:44:34 +0000 (23:44 +0000)]
Merge "Remove jpegutiltest for ub-camera-haleakala" into ub-camera-haleakala
Alan Newberger [Thu, 14 May 2015 23:39:24 +0000 (16:39 -0700)]
Remove jpegutiltest for ub-camera-haleakala
This test breaks on mnc-dev toolchain, not critical for operation.
Change-Id: Icad375c9d1d7a943168d88241e69276d7536df61
Gabriel Nava [Wed, 13 May 2015 18:44:13 +0000 (11:44 -0700)]
Fix for crash when switching cameras on KitKat (camera-haleakala)
- Adding null check for hardwareSpec in CameraAppUI.onChangeCamera()
- Hardware spec may not be available if call to get camera parameters hasn't finished yet
Bug:
21118170
Change-Id: I5bf1b0328f2cae7211464ff136a31ace2577630f
Geoff Mendal [Wed, 13 May 2015 13:49:41 +0000 (06:49 -0700)]
Import translations. DO NOT MERGE
Change-Id: Ia40e98cbd91bc955da9f01c1be57d9ecfc79c1d1
Auto-generated-cl: translation import
Pengchong Jin [Wed, 13 May 2015 00:41:34 +0000 (00:41 +0000)]
Merge "WAR of the face detection failure" into ub-camera-haleakala
Gabriel Nava [Tue, 12 May 2015 21:31:45 +0000 (21:31 +0000)]
Merge "Ensuring the right HDR icon is shown on camera switch (camera-haleakala)" into ub-camera-haleakala
Alan Newberger [Tue, 12 May 2015 21:01:06 +0000 (21:01 +0000)]
Merge "skip first run dialog when starting in secure mode" into ub-camera-haleakala
Alan Newberger [Tue, 12 May 2015 20:39:54 +0000 (13:39 -0700)]
skip first run dialog when starting in secure mode
Go right into camera mode when starting from secure lockscreen, this
restores prior behavior and avoids resume loops in double onResume
workarounds.
Bug:
21070237
Change-Id: I353bdd4b73c8c63e58710e35304b5c269458c72e
Gabriel Nava [Tue, 12 May 2015 18:51:07 +0000 (11:51 -0700)]
Ensuring the right HDR icon is shown on camera switch (camera-haleakala)
- When switching cameras HDR+ icon was always shown in disabled state regardless of the actual support mode
- Existing boolean setting to track device's HDR support is not enough
- Changing global device's HDR support setting to string that can hold no-hdr, hdr or hdr-plus values
Bug:
21037428
Change-Id: Ia9cf0484879a22a27e4deb0e4aa066ec806a43e6
Gabriel Nava [Tue, 12 May 2015 17:26:20 +0000 (17:26 +0000)]
Merge "Freezing preview in capture intent when image is exposed instead of shutter click (camera-haleakala)" into ub-camera-haleakala
Pengchong Jin [Sat, 9 May 2015 03:55:57 +0000 (20:55 -0700)]
WAR of the face detection failure
This patch gives a work-around of the face detection failure that
occurs when the ZSL camera is used. It forces to request a preview
frame followed by a 5-frame ZSL burst before requesting the repeated
preview and ZSL streams. It also hides the first preview frame in order
to avoid potential janks. We do this only for L, Nexus 6 and Haleakala.
Bug:
20724126
Change-Id: I40b7861e07570ed53135b2d8d182b65c5799adac
Gabriel Nava [Mon, 11 May 2015 20:29:16 +0000 (13:29 -0700)]
Freezing preview in capture intent when image is exposed instead of shutter click (camera-haleakala)
- Removing preview freeze call from shutter button callback
- Relocating preview freeze call to quick expose handler
Bug:
20957671
Change-Id: Ie1c68ed52e04cdafd6f5894d001990a030d15761
Paul Rohde [Mon, 11 May 2015 18:45:18 +0000 (18:45 +0000)]
Merge "Hide no active camera NPE by defaulting to camera device -1" into ub-camera-haleakala
Paul Rohde [Mon, 11 May 2015 18:29:21 +0000 (11:29 -0700)]
Hide no active camera NPE by defaulting to camera device -1
NPE's can occur if no camera device is currently active. It's
not feasable to rewire all parts of the codebase for this
release to properly access the target camera device. This
fix may lead to inconsistent setting persistance if in places
where a NPE would otherwise occur.
Bug:
21026362
Change-Id: I76c5b5fab429f61238a1ba91c0c52e839a431573
Alan Newberger [Mon, 11 May 2015 17:10:26 +0000 (10:10 -0700)]
Fall back to bounds if provided width/height is 0
Monkey results show async dimensions can lag behind
automated filmstrip. Protect against this case, should
reduce monkey issues.
Bug:
21023148
Change-Id: I8fef5e8d00f96c4b4c249b3a9daebfcf9991e193
Senpo Hu [Fri, 8 May 2015 21:18:49 +0000 (14:18 -0700)]
[ImageIntent] Support volume / camera key to take photo.
Bug:
20947910
Change-Id: I01e49840b69926b1489d6564a8b183d653b71ac1
Gabriel Nava [Wed, 6 May 2015 23:06:50 +0000 (16:06 -0700)]
Opening the right camera on app restart when using PhotoModule (camera-haleakala)
- In existing logic PhotoModule reverts to back camera if no aspect ratio has been selected
- Reverting to Back camera only if device allows showing the aspect ratio dialog (N4,N5,N6)
- Updating the Camera ID persistent setting if reverting, not only the runtime value
Bug:
20889927
Change-Id: Ie59b878fd03da751c552fbf92ec5c96889144016
Alan Newberger [Wed, 6 May 2015 19:55:49 +0000 (12:55 -0700)]
Refresh metadata for every filmstrip item update.
Current filmstrip item updates:
1. call CameraFilmstripDataAdapter.updateItemAt which then calls FilmstripView.updateViewItem
2. FilmstripView.updateViewItem updates the view then calls CameraActivity.updateUiByData
3. CameraActivity.updateUiByData calls CameraFilmstripDataAdapter.updateMetadataAt
4. MetadataUpdateTask calls FilmstripView.updateViewItem again if metadata was loaded
The double updateViewItems disrupts SessionItem -> PhotoItem transitions, and for some
reason for LB causes the second updateViewItem to only request tiny thumbnails. For a very targeted
fix, we instead make step 1 do the metadata load, and then updateViewItem is only called once. The
code in step 3 still executes but is a no-op since metadata was already loaded in step one.
Tested with Camera mode, Pano/PhotoSphere, LB, redoing an LB, calling out to editor and changing a
photo, and taking a video.
Bug:
20862631
Change-Id: Ib8b112c2ef1b5a364a5569d1391ef359d1b5fb1a
Gabriel Nava [Mon, 4 May 2015 20:44:56 +0000 (13:44 -0700)]
Preventing camera button to get into wrong state when pressed in succession (camera-haleakala)
- Adding methods to ButtonManager to enable/disable camera button explicitly
- Camera button cannot be enabled during initialization if it was explicitly disabled
- PhotoModule, VideoModule and CaptureModule enable/disable camera button on camera switch
- Capture button is disabled before requesting the camera switch
- Capture button is re-enabled once the camera open confirmation is received
Bug:
20693214
Change-Id: I6383c705eee0a82397b975332cf37bbcd5913128
Gabriel Nava [Mon, 4 May 2015 20:09:25 +0000 (20:09 +0000)]
Merge "Avoid camera switch while HDR activation is in progress (camera-haleakala)" into ub-camera-haleakala
Gabriel Nava [Fri, 1 May 2015 22:45:36 +0000 (15:45 -0700)]
Avoid camera switch while HDR activation is in progress (camera-haleakala)
- Adding pre-change listener to MultiToggleImageButton to be executed before running state change animations
- Allowing button initialization with pre-change callback in ButtonManager
- Adding pre-change callback for conflicting options in CameraAppUI:
HDR/HDR+ button disables camera button to avoid camera facing switch
Camera facing disables HDR/HDR+
- Conflicting button is shown in disabled state for a while until re-enabled if applicable when the module switch is completed
Bug:
20696068
Change-Id: I11a0a0567363f656be52a9ece0707ccf326f2d67
Paul Rohde [Fri, 1 May 2015 22:34:45 +0000 (22:34 +0000)]
Merge "Check for a potentially destroyed activity before startPreview." into ub-camera-haleakala
Pengchong Jin [Fri, 1 May 2015 22:24:54 +0000 (22:24 +0000)]
Merge "Fix bug b/
20638423" into ub-camera-haleakala
Gabriel Nava [Fri, 1 May 2015 22:17:02 +0000 (22:17 +0000)]
Merge "Disabling non available options instead of hiding when hw support is present (camera-haleakala)" into ub-camera-haleakala
Paul Rohde [Thu, 30 Apr 2015 18:08:23 +0000 (11:08 -0700)]
Check for a potentially destroyed activity before startPreview.
There is a small chance that the activity can be destroyed
between the time the camera is created and the preview is started.
This can lead to unchecked NPE's across the app because most code
assumes that there will never be a case where activity objects
are accessed after onDestroy.
Bug:
20097425
Change-Id: I2904ffba451ded2417a806c83fd12e4f62611150
Gabriel Nava [Fri, 1 May 2015 16:28:50 +0000 (09:28 -0700)]
Disabling non available options instead of hiding when hw support is present (camera-haleakala)
- Global scope property persists the support of flash and hdr for the main camera (back)
- If option is not supported at all, option is hidden
- If option is supported in at least one camera but not supported in current module, option is disabled
- If option is supported in current module, option is enabled
- Avoiding race condition where CameraAppUI.applyModuleSpecs was bein called multiple times simultaneously for the same change
- Adding a check so BottomBar UI is updated only when there's a scope (module/camera) change, unless...
- Scope check can be requested within same scope for settings change
Bug:
20630060
Change-Id: Iac5fa2658f04fe8329a2232fb0d5b11d20e566a2
Pengchong Jin [Thu, 30 Apr 2015 21:11:16 +0000 (14:11 -0700)]
Fix bug b/
20638423
Catch the AssertionError exception thrown by
CameraAgentFactory.getAndroidCameraAgent, and pop up the reporting
dialog before App termination.
Bug:
20638423
Change-Id: I090ea03b7ff872b40f4b0cc6bcbb33e41f332920
Pengchong Jin [Fri, 1 May 2015 06:06:16 +0000 (06:06 +0000)]
Merge "Fix bug b/
19965993" into ub-camera-haleakala
Senpo Hu [Fri, 1 May 2015 00:42:40 +0000 (00:42 +0000)]
Merge "Freeze preview after taking shot in capture intent." into ub-camera-haleakala
Senpo Hu [Thu, 30 Apr 2015 23:23:15 +0000 (16:23 -0700)]
Freeze preview after taking shot in capture intent.
Bug:
20690039
Change-Id: I3402b7d7acb956a886596267ca37bd129ba74e3c
Pengchong Jin [Thu, 30 Apr 2015 22:25:13 +0000 (15:25 -0700)]
Fix bug b/
19965993
CameraId null check before checking whether the exposure compensation is
supported.
Bug:
19965993
Change-Id: If5cd7fbfe9ae6d2f83e56c8647836f96fa6e7426
I-Jong Lin [Thu, 30 Apr 2015 22:08:05 +0000 (22:08 +0000)]
Merge "Fix for N4 Video and inclusion of CaptureIntent" into ub-camera-haleakala
I-Jong Lin [Thu, 30 Apr 2015 21:23:28 +0000 (14:23 -0700)]
Fix for N4 Video and inclusion of CaptureIntent
Bug:
20694189
Workaround b/
19271661 needs to specifically applied in
these circumstances only:
1. Phone is Nexus4
2. CaptureModule is enabled
3. Photo Mode, OR Capture Intent Photo is enabled.
Since we are passing the CameraActivity in TextureViewHelper,
it has enough context to know everything. Previous implementation
used an invalid CameraProvider to signal that Camera2 was enabled.
Now we just ask the CameraActivity directly.
Change-Id: I47f841ae6476bc034a7ad3f487c40616eed05b71
Sascha Haeberling [Thu, 30 Apr 2015 21:24:57 +0000 (14:24 -0700)]
Make sure we cancel countdown before mPaused is set.
Bug:
20696312
Change-Id: I3785a46881e2bb027d0cd06d1c2eba1b38ca2b4a
Sascha Haeberling [Thu, 30 Apr 2015 19:58:54 +0000 (12:58 -0700)]
Lower the priority of ProcessingService to 'background'.
Bug:
20675397
This should e.g. greatly reduce the jank we see while Lens Blurs are
processing.
Change-Id: I7ffd9bb394a113b913105a6e91c8f12fc067bfbb
I-Jong Lin [Thu, 30 Apr 2015 01:18:26 +0000 (01:18 +0000)]
Merge "Fix for N4 Video Rotation Bug" into ub-camera-haleakala